Force a space after '!'

Author: colinodell

src/Unleashed/ruleset.xml

@@ -55,12 +55,8 @@
             <property name="spacing" value="1"/>
         </properties>
     </rule>
-    <!-- Force no whitespace after `!` -->
-    <rule ref="Generic.Formatting.SpaceAfterNot">
-        <properties>
-            <property name="spacing" value="0" />
-        </properties>
-    </rule>
+    <!-- Force whitespace after `!` -->
+    <rule ref="Generic.Formatting.SpaceAfterNot"/>
     <!-- Forbid PHP 4 constructors -->
     <rule ref="Generic.NamingConventions.ConstructorName"/>
     <!-- Forbid any content before opening tag -->

tests/fixed/EarlyReturn.php

@@ -14,7 +14,7 @@ public function bar(): bool
     public function foo(): ?string
     {
         foreach ($itens as $item) {
-            if (!$item->isItem()) {
+            if (! $item->isItem()) {
                 return 'There is an item that is not an item';
             }
 

tests/fixed/UselessConditions.php

@@ -94,7 +94,7 @@ public function necessaryIfConditionWithMethodCall(): bool
 
     public function nullShouldNotBeTreatedAsFalse(): ?bool
     {
-        if (!$this->isAdmin) {
+        if (! $this->isAdmin) {
             return null;
         }
 

tests/fixed/example-class.php

@@ -68,7 +68,7 @@ public function isBaz(): bool
      */
     public function mangleBar(int $length): void
     {
-        if (!$this->baz) {
+        if (! $this->baz) {
             throw new \InvalidArgumentException();
         }
 

tests/fixed/not_spacing.php

@@ -6,18 +6,18 @@
 
 $test++;
 
-if (!$test > 0) {
+if (! $test > 0) {
     echo 1;
-} elseif (!$test === 0) {
+} elseif (! $test === 0) {
     echo 0;
 } else {
     echo -1;
 }
 
-while (!true) {
+while (! true) {
     echo 1;
 }
 
 do {
     echo 1;
-} while (!true);
+} while (! true);

tests/fixed/null_coalesce_operator.php

@@ -16,4 +16,4 @@
 
 $fooBar = isset($foo, $bar) ? 'foo' : 'bar';
 
-$baz = !isset($foo) ? 'foo' : 'baz';
+$baz = ! isset($foo) ? 'foo' : 'baz';

tests/fixed/useless-semicolon.php

@@ -2,13 +2,13 @@
 
 declare(strict_types=1);
 
-while (!true) {
+while (! true) {
     echo 1;
 }
 
 do {
     echo 1;
-} while (!false);
+} while (! false);
 
 for (;;) {
     echo 'To infity and beyond';

tests/input/EarlyReturn.php

@@ -18,7 +18,7 @@ public function bar(): bool
     public function foo(): ?string
     {
         foreach ($itens as $item) {
-            if (!($item->isItem())) {
+            if (! ($item->isItem())) {
                 return 'There is an item that is not an item';
             } else {
                 continue;

tests/input/UselessConditions.php

@@ -126,7 +126,7 @@ public function necessaryIfConditionWithMethodCall(): bool
 
     public function nullShouldNotBeTreatedAsFalse(): ?bool
     {
-        if (!$this->isAdmin) {
+        if (! $this->isAdmin) {
             return null;
         }
 

tests/input/example-class.php

@@ -70,7 +70,7 @@ public function isBaz(): bool
      */
     public function mangleBar(int $length) : void
     {
-        if (!$this->baz) {
+        if (! $this->baz) {
             throw new \InvalidArgumentException();
         }
 

tests/input/null_coalesce_operator.php

@@ -16,4 +16,4 @@
 
 $fooBar = isset($foo, $bar) ? 'foo' : 'bar';
 
-$baz = !isset($foo) ? 'foo' : 'baz';
+$baz = ! isset($foo) ? 'foo' : 'baz';

tests/input/useless-semicolon.php

@@ -2,13 +2,13 @@
 
 declare(strict_types=1);
 
-while (!true) {
+while (! true) {
     echo 1;
 };
 
 do {
     echo 1;
-} while (!false);
+} while (! false);
 
 for (;;) {
     echo 'To infity and beyond';

tests/php-compatibility.patch

@@ -17,7 +17,7 @@ index eee1c6f..742226e 100644
          'array_key_exists'     => true,
          'array_slice'          => true,
 diff --git a/tests/expected_report.txt b/tests/expected_report.txt
-index 1ecfaaa..30d43c6 100644
+index 1ecfaaa..06d22b0 100644
 --- a/tests/expected_report.txt
 +++ b/tests/expected_report.txt
 @@ -6,45 +6,46 @@ FILE                                                  ERRORS  WARNINGS
@@ -49,7 +49,8 @@ index 1ecfaaa..30d43c6 100644
 +tests/input/NamingCamelCase.php                       8       0
  tests/input/negation-operator.php                     2       0
  tests/input/new_with_parentheses.php                  18      0
- tests/input/not_spacing.php                           6       0
+-tests/input/not_spacing.php                           6       0
++tests/input/not_spacing.php                           8       0
  tests/input/null_coalesce_operator.php                3       0
 -tests/input/optimized-functions.php                   1       0
 -tests/input/return_type_on_closures.php               29      0
@@ -77,15 +78,15 @@ index 1ecfaaa..30d43c6 100644
 +tests/input/UselessConditions.php                     23      0
  ----------------------------------------------------------------------
 -A TOTAL OF 388 ERRORS AND 2 WARNINGS WERE FOUND IN 38 FILES
-+A TOTAL OF 364 ERRORS AND 2 WARNINGS WERE FOUND IN 39 FILES
++A TOTAL OF 366 ERRORS AND 2 WARNINGS WERE FOUND IN 39 FILES
  ----------------------------------------------------------------------
 -PHPCBF CAN FIX 331 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
-+PHPCBF CAN FIX 307 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
++PHPCBF CAN FIX 309 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
  ----------------------------------------------------------------------
 
 
 diff --git a/tests/fixed/example-class.php b/tests/fixed/example-class.php
-index 9df3d20..108bb03 100644
+index 0f98ce6..050d89c 100644
 --- a/tests/fixed/example-class.php
 +++ b/tests/fixed/example-class.php
 @@ -18,14 +18,12 @@ class Example implements \IteratorAggregate