Deleting the override doesn't remove it from the overrides. Refreshing it will give you a client side error.

[harshsbhat]

Preliminary Checks

• I have reviewed the documentation: https://unkey.com/docs

• I have searched for existing issues: https://github.com/unkeyed/unkey/issues

• This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.

Reproduction / Replay Link (Optional)

No response

Issue Summary

After deleting the override it is still displayed in the overrides. If you click on it the whole UI breaks

Steps to Reproduce

1. Go to a /ratelimit and create a new ratelimit
2. Create a new override and delete it.
3. It is still displayed under all overrides.
4. If you refresh it the whole UI will break
   

Expected behavior

Once deleted it should not be visbile in the ratelimit/id/overrides .

Other information

No response

Screenshots

https://www.loom.com/share/030e5263e3ea44c5bdc1d03c882b790a?sid=53973849-b8a4-49a0-9c5d-18fc91b79fe4

Version info

- OS:
- Node:
- npm:

[linear]

ENG-1397 Deleting the override doesn't remove it from the overrides. Refreshing it will give you a client side error.

[chronark]

We're probably not checking the deletedAt column when doing the query to list all ratelimits

that should fix this I believe

[chronark]

/award 150

[oss-gg]

Awarding harshsbhat: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshsbhat

[HarshitVashisht11]

/assign

[oss-gg]

Assigned to @HarshitVashisht11! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[oss-gg]

@HarshitVashisht11, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

[AakashRao-dev]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[HarshitVashisht11]

/unassign

[oss-gg]

Issue unassigned.

[alokdangre]

/assign

[oss-gg]

Assigned to @Studycode001! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[Usmanxs]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[shindebhavika]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[nilaygit-10721]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[aniket607]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[no-naame]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[Vardhaman619]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[harshsbhat]

@Studycode001 Hey are you working on this? Since it has been 3 weeks I would like to take over if you are not working on it.