Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make return value never undefined if passing acceptCloudflareNotice: true #60

Open
1 task done
chadxz opened this issue Feb 19, 2025 · 0 comments
Open
1 task done

Make return value never undefined if passing acceptCloudflareNotice: true #60

chadxz opened this issue Feb 19, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@chadxz
Copy link

chadxz commented Feb 19, 2025

Describe the feature

This is a small thing but it would be nice if the startTunnel() return type did not include undefined if I pass acceptCloudflareNotice: true as an option. Looking at the code, the only scenario it would be undefined is if it wasn't accepted.

I'm no TypeScript wizard but it seems like it may be possible?

Additional information

  • Would you be willing to help implement this feature?
@chadxz chadxz added the enhancement New feature or request label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chadxz