Support font optimization in Google Fonts and Google Icons #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushichan044
commented
Dec 18, 2024
| }) | ||
|
|
||
| // Do not use sanitizeFontSource here, as we must test the url parameters | ||
| expect(fonts).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
Since the URL parameters were the only way to verify that the correctly optimized fonts were resolved, I did a snapshot test.
sushichan044
force-pushed
the
feat/issue-61-font-optimization
branch
from
5583eac to
59a38e8
Compare
|
Because of the different endpoints, using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
glyphsoption for specifying characters and icons to fetch.Users can resolve minimized fonts by using the
glyphsoption in Google Fonts and Google Icons.