From af921107cb2593d755698f5bc99531a4f540b811 Mon Sep 17 00:00:00 2001 From: Victor Berchet Date: Fri, 29 Nov 2024 17:13:28 +0100 Subject: [PATCH] refactor: use `node:events` instead of relative path (#354) --- src/runtime/node/http/internal/request.ts | 1 + src/runtime/node/http/internal/response.ts | 1 + src/runtime/node/net/internal/socket.ts | 1 + src/runtime/node/stream/internal/readable.ts | 2 +- src/runtime/node/stream/internal/writable.ts | 2 +- src/runtime/node/tls/internal/server.ts | 1 + src/runtime/node/tls/internal/tls-socket.ts | 1 + src/runtime/node/tty/internal/read-stream.ts | 1 + 8 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/runtime/node/http/internal/request.ts b/src/runtime/node/http/internal/request.ts index 9632ac08..b151b9a2 100644 --- a/src/runtime/node/http/internal/request.ts +++ b/src/runtime/node/http/internal/request.ts @@ -1,5 +1,6 @@ import type http from "node:http"; import { Socket } from "node:net"; +// Relative stream import required, see https://github.com/unjs/unenv/issues/353 import { Readable } from "../../stream/internal/readable"; import { rawHeaders } from "../../../_internal/utils"; diff --git a/src/runtime/node/http/internal/response.ts b/src/runtime/node/http/internal/response.ts index 3e0def13..0c90370b 100644 --- a/src/runtime/node/http/internal/response.ts +++ b/src/runtime/node/http/internal/response.ts @@ -1,6 +1,7 @@ import type http from "node:http"; import type { Socket } from "node:net"; import { Callback } from "../../../_internal/types"; +// Relative stream import required, see https://github.com/unjs/unenv/issues/353 import { Writable } from "../../stream"; // Docs: https://nodejs.org/api/http.html#http_class_http_serverresponse diff --git a/src/runtime/node/net/internal/socket.ts b/src/runtime/node/net/internal/socket.ts index 777a287d..1e9ed9fe 100644 --- a/src/runtime/node/net/internal/socket.ts +++ b/src/runtime/node/net/internal/socket.ts @@ -1,5 +1,6 @@ import type * as net from "node:net"; import { Callback, BufferEncoding } from "../../../_internal/types"; +// Relative stream import required, see https://github.com/unjs/unenv/issues/353 import { Duplex } from "../../stream/internal/duplex"; // Docs: https://nodejs.org/api/net.html#net_class_net_socket diff --git a/src/runtime/node/stream/internal/readable.ts b/src/runtime/node/stream/internal/readable.ts index d7d56c5e..b06216f1 100644 --- a/src/runtime/node/stream/internal/readable.ts +++ b/src/runtime/node/stream/internal/readable.ts @@ -1,7 +1,7 @@ import type * as stream from "node:stream"; import type { BufferEncoding, Callback } from "../../../_internal/types"; import { createNotImplementedError } from "../../../_internal/utils"; -import { EventEmitter } from "../../events"; +import { EventEmitter } from "node:events"; // Docs: https://nodejs.org/api/stream.html#stream_readable_streams // Implementation: https://github.com/nodejs/node/blob/master/lib/internal/streams/readable.js diff --git a/src/runtime/node/stream/internal/writable.ts b/src/runtime/node/stream/internal/writable.ts index 6ee7be37..bb48e6a8 100644 --- a/src/runtime/node/stream/internal/writable.ts +++ b/src/runtime/node/stream/internal/writable.ts @@ -1,7 +1,7 @@ import type * as stream from "node:stream"; import type { BufferEncoding, Callback } from "../../../_internal/types"; -import { EventEmitter } from "../../events"; +import { EventEmitter } from "node:events"; // Docs: https://nodejs.org/api/stream.html#stream_writable_streams // Implementation: https://github.com/nodejs/node/blob/master/lib/internal/streams/writable.js diff --git a/src/runtime/node/tls/internal/server.ts b/src/runtime/node/tls/internal/server.ts index d42f2f73..4a1f39fa 100644 --- a/src/runtime/node/tls/internal/server.ts +++ b/src/runtime/node/tls/internal/server.ts @@ -1,5 +1,6 @@ import type tls from "node:tls"; import { createNotImplementedError } from "../../../_internal/utils"; +// Relative net import required, see https://github.com/unjs/unenv/issues/353 import { Server as _Server } from "../../net"; export class Server extends _Server implements tls.Server { diff --git a/src/runtime/node/tls/internal/tls-socket.ts b/src/runtime/node/tls/internal/tls-socket.ts index 6e754320..3aceb4dc 100644 --- a/src/runtime/node/tls/internal/tls-socket.ts +++ b/src/runtime/node/tls/internal/tls-socket.ts @@ -1,4 +1,5 @@ import type tls from "node:tls"; +// Relative net import required, see https://github.com/unjs/unenv/issues/353 import { Socket } from "../../net"; import { createNotImplementedError } from "../../../_internal/utils"; diff --git a/src/runtime/node/tty/internal/read-stream.ts b/src/runtime/node/tty/internal/read-stream.ts index e8aec2dc..4ace7514 100644 --- a/src/runtime/node/tty/internal/read-stream.ts +++ b/src/runtime/node/tty/internal/read-stream.ts @@ -1,4 +1,5 @@ import type tty from "node:tty"; +// Relative net import required, see https://github.com/unjs/unenv/issues/353 import { Socket } from "../../net"; export class ReadStream extends Socket implements tty.ReadStream {