Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util to dedup dependencies #166

Open
1 task done
OrbisK opened this issue Nov 28, 2024 · 5 comments · May be fixed by #175
Open
1 task done

util to dedup dependencies #166

OrbisK opened this issue Nov 28, 2024 · 5 comments · May be fixed by #175
Labels
enhancement New feature or request

Comments

@OrbisK
Copy link

OrbisK commented Nov 28, 2024

Describe the feature

Follow up of: nuxt/cli#573 (comment)

nypm should support dedupe.

Package manager support

npm

npm should have build in dedupe https://docs.npmjs.com/cli/v10/commands/npm-dedupe

pnpm

https://pnpm.io/cli/dedupe

yarn

https://yarnpkg.com/cli/dedupe

bun

planned: oven-sh/bun#8594 (comment)

deno

?

Additional information

  • Would you be willing to help implement this feature?
@OrbisK OrbisK added the enhancement New feature or request label Nov 28, 2024
@OrbisK
Copy link
Author

OrbisK commented Nov 28, 2024

@danielroe
I would implement it, but i am not sure how to handle not supporting bun and deno.

@pi0 pi0 changed the title feat: nypm dedupe install with dedup Nov 28, 2024
@pi0 pi0 changed the title install with dedup util to dedup dependencies Nov 28, 2024
@pi0
Copy link
Member

pi0 commented Nov 28, 2024 •
edited
Loading

For the first step, I think we can throw an error from dedupDependencies() / nypm dedup this way nuxi can fallback to a warning or prompt for alternatives.

In next step I like to introduce a util for upgrading deps with different options but that might take longer.

@OrbisK
Copy link
Author

OrbisK commented Nov 28, 2024

For the first step, I think we can throw an error from util / cli this way nuxi can fallback to a warning or prompt for alternatives.

In next step I like to introduce a util for upgrading deps with different options but that might take longer.

so i should start or wait for the upgrading? :)

@pi0
Copy link
Member

pi0 commented Nov 28, 2024

Feel free to start it will unblock nuxi :)

OrbisK added a commit to OrbisK/nypm-fork that referenced this issue Dec 28, 2024
@OrbisK
feat: add dedupe util
9035bbd 
fix unjs#166
@OrbisK OrbisK linked a pull request Dec 28, 2024 that will close this issue
Open
@OrbisK
Copy link
Author

OrbisK commented Dec 28, 2024

Feel free to start it will unblock nuxi :)

i have added it. i hope it fits like this

OrbisK added a commit to OrbisK/nypm-fork that referenced this issue Dec 28, 2024
@OrbisK
feat: add dedupe util
c1abb52 
fix unjs#166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add dedupeDependencies utility OrbisK/nypm-fork
2 participants
@pi0 @OrbisK