We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node v20.18.0, [email protected]
mlly.hasESMSyntax(`/* export * */`, { stripComments: false }) // true ✅ mlly.hasESMSyntax(`/* export * */`, { stripComments: true }) // false ✅ mlly.hasESMSyntax(`/* export * */`, { stripComments: true }) // true ❌
The strip comments functionality does not handle multiline comments resulting in incorrect results for hasESMSyntax and isValidNodeImport.
hasESMSyntax
isValidNodeImport
No response
The text was updated successfully, but these errors were encountered:
fix: comment stripping should remove multiline comments (unjs#279)
918e835
fix: use acorn to strip comments (unjs#279)
e6d34a2
176fb90
c4ab502
Successfully merging a pull request may close this issue.
Environment
Node v20.18.0, [email protected]
Reproduction
Describe the bug
The strip comments functionality does not handle multiline comments resulting in incorrect results for
hasESMSyntax
andisValidNodeImport
.Additional context
No response
Logs
No response
The text was updated successfully, but these errors were encountered: