feat: persist and reuse generated https certificates #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mastercuber
force-pushed
the
persist-https-certs
branch
from
417412b to
542cdaf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 49.42% 50.48% +1.06%
==========================================
Files 17 17
Lines 1819 1844 +25
Branches 147 148 +1
==========================================
+ Hits 899 931 +32
+ Misses 915 908 -7
Partials 5 5 ☔ View full report in Codecov by Sentry. |
pi0
reviewed
Nov 6, 2023
src/_cert.ts
Outdated
| const key = await fs.readFile(certificateDirectory + "cert-key.pem"); | ||
| return { | ||
| cert: cert.toString("utf8"), | ||
| key: key.toString("utf8"), |
There was a problem hiding this comment.
I think we could perform both keys in a single JSON file. Mainly to simplify fs but also having possibility to for example have multiple generated keys cached in one read/write + having more meta
There was a problem hiding this comment.
This commit introduces these change
Mastercuber
force-pushed
the
persist-https-certs
branch
2 times, most recently
from
536868b to
73dc5be
Compare
|
@pi0 Is there something else needed for this to get merged? |
Mastercuber
force-pushed
the
persist-https-certs
branch
from
73dc5be to
55cc0fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
closes #132
❓ Type of change
📚 Description
In this PR a new flag (
--https.reuse) is introduced to be able to reuse previosly autogenerated certificates, instead of generating them every timelisthenis restarted.📝 Checklist