Doesn't work on mac

[unitoftime]

2022/06/16 02:51:30 failed diffues
panic: loadShader: ERROR: 0:1: '' : version '300' is not supported
ERROR: 0:1: '' : syntax error: #version
ERROR: 0:2: '' : #version required and missing.
ERROR: 0:3: '0' : syntax error: integers in layouts require GLSL 140 or later

goroutine 19 [running]:
main.runGame()
/Users/____/Documents/GitHub/raylib-game-1/main.go:27 +0xe4c
github.com/faiface/mainthread.Run.func1()
/Users//go/pkg/mod/github.com/faiface/mainthread@v0.0.0-20171120011319-8b78f0a41ae3/mainthread.go:37 +0x26
created by github.com/faiface/mainthread.Run
/Users//go/pkg/mod/github.com/faiface/mainthread@v0.0.0-20171120011319-8b78f0a41ae3/mainthread.go:36 +0xb8
exit status 2

[unitoftime]

Todo - buy a mac

[nathany]

It was a small change to get go run examples/simple/main.go running on macOS 15.5, but it may be a bigger change to support both macOS and WebGL 2 at the same time.

Without #13 ANGLE, macOS doesn't support OpenGL ES. It also doesn't appear to have shader language 300 listed in GLview.

To get it to run, I tried using shader version 330 without the ES suffix.

[nathany]

Prepending the shader version at runtime instead of including it in the shader files may be a suitable solution?

[unitoftime]

Interesting... Thanks for investigating!

Originally I planned for default shaders to use a kind of "minimum" glsl version that every system can support, but if that is infeasible because of macOS and webgl2 not sharing a glsl version, then I'd be fine with letting the shader (or glitch runtime) determine what shader version we want to use. Notably, because users can write and create their own custom shaders, they would also need an easy way to use the "platform-default" glsl shader version.

I'm not really sure the best solution implementation-wise. but ideas that come to mind are:

1. Let users template certain fields in their shaders. For example: {{ .DefaultShaderVersion }} (or something)
2. Modify the Shader struct to have a separate field for version, then expect the shader code to not contain the version.

For idea 1, I'm not really sure where else templating would be useful. And for idea 2, I feel like it's confusing to write a glsl file without the shader version at the top. So I'm not a huge fan of either of my ideas.

Let me know if you have any better ones!
Thanks!

[nathany]

Those both sound like solid ideas. I'm not sure if I have any better ones, but brainstorming here:

3. Another solution would be to override the version present in the shader, which could just be automatic (seems kinda hacky), or specified somehow (e.g. like idea 2 or maybe a platform level override)
4. Support having different shader files for each platform, whether required or an optional override. But I don't know that there would be any differences besides the version number? This might be a good direction if planning to support multiple backends, but that has complications in itself (e.g. Metal has a single shader for vertex and fragment)
5. Leave it as is, or defer until later. You don't have a Mac to test on, and WebGL is another option for end-users.

[unitoftime]

Yeah. Good ideas. At this point I'm fine with leaving it as is, I don't really have a macOS usecase for Mythfall. But if someone else wants it for their use case, they can either manually set their shaders or submit a patch.