-
Notifications
You must be signed in to change notification settings - Fork 285
MCP Update tool #5952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCP Update tool #5952
Conversation
65d52b8 to
3619e45
Compare
|
Let's do the thing where we mark it as destructive but otherwise don't block. |
|
Even if it did delete a branch I think you could still get it back with the global reflog, but obviously not ideal. Okay sounds like a plan 👍🏼 |
3619e45 to
cda78b2
Compare
|
@aryairani Okay I removed the branch-protection stuff. |
|
I'm dogfooding it now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay and ensuing conflicts; this is great. Could you update the PR description to confirm --mcp-editable-branches= isn't a thing anymore; can just strikeout it if desired
93f7a43 to
872ac93
Compare
Overview
This requires the user to explicitly mark a branch as editable by the mcp by passing theNow we just rely on the agent respecting the 'destructive updates' flag, caveat emptor.--mcp-editable-branches=<project/branch regex>flag in their MCP config. We can continue to explore other options for this.Implementation notes
Adds the new global--mcp-editable-branches=<project/branch regex>flagupdatetoolTest coverage
Added an API transcript test
Could use some dogfooding and testing in the wile before merging/releasing
Loose ends
May want to explore other methods of allowing mcp edits on certain branches, editing your config file and restarting your agent every time is a pain.