Merge pull request #5892 from unisonweb/runarorama/integersignum

Fix the return type of Integer.signum

Author: pchiusano

unison-runtime/src/Unison/Runtime/Foreign/Function.hs

@@ -1123,7 +1123,7 @@ foreignCallHelper = \case
   Integer_ge -> mkForeign $ \(l :: Integer, r :: Integer) -> pure $ encodeVal (l >= r)
   Integer_neg -> mkForeign $ \(n :: Integer) -> pure $ encodeVal (-n)
   Integer_abs -> mkForeign $ \(n :: Integer) -> pure $ encodeVal (abs n)
-  Integer_signum -> mkForeign $ \(n :: Integer) -> pure $ encodeVal (signum n)
+  Integer_signum -> mkForeign $ \(n :: Integer) -> pure $ encodeVal (fromIntegral (signum n) :: Int)
   Integer_toFloat -> mkForeign $ \(n :: Integer) -> pure $ encodeVal (fromIntegral n :: Double)
   Natural_unsafeFromText -> mkForeign $ \(txt :: Text) -> case readMaybe (unpack txt) of
     Just n -> pure $ encodeVal (n :: Natural)

unison-src/transcripts/idempotent/builtins.md

@@ -252,7 +252,8 @@ test> Integer.tests.arithmetic =
         Integer.eq (Integer.fromInt +1000) (Integer.fromInt +1000),
         not (Integer.eq (Integer.fromInt +1000) (Integer.fromInt +999)),
         eq (Integer.abs (Integer.fromInt +1000)) (Integer.fromInt +1000),
-        eq (Integer.abs (Integer.fromInt -1000)) (Integer.fromInt +1000)
+        eq (Integer.abs (Integer.fromInt -1000)) (Integer.fromInt +1000),
+        not (Int.eq (Integer.signum (Integer.fromInt +1)) (Integer.signum (Integer.fromInt -1)))
         ]
 
 test> Integer.tests.bitwise =