Correctly fetch definitions via workspace

Author: hojberg

elm-git.json

@@ -1,7 +1,7 @@
 {
     "git-dependencies": {
         "direct": {
-            "https://github.com/unisonweb/ui-core": "73ffa9d42290ce3d5deeb80acc19f4606b2f7685"
+            "https://github.com/unisonweb/ui-core": "7d8d5f9ee2e6de17f385e1ce90e87cc5b60e9c6e"
         },
         "indirect": {}
     }

src/UnisonLocal/Api.elm

@@ -81,14 +81,26 @@ codebaseApiEndpointToEndpoint cbEndpoint =
 
         CodebaseApi.Definition { perspective, ref } ->
             let
-                re =
-                    Maybe.withDefault Regex.never (Regex.fromString "#[d|a|](\\d+)$")
+                constructorSuffixRegex =
+                    Maybe.withDefault Regex.never (Regex.fromString "#[ad]\\d$")
 
-                stripConstructorPositionFromHash =
-                    Regex.replace re (always "")
+                withoutConstructorSuffix h =
+                    h
+                        |> Hash.toString
+                        |> Regex.replace constructorSuffixRegex (always "")
+
+                refToString r =
+                    case Reference.hashQualified r of
+                        HQ.NameOnly fqn ->
+                            FQN.toApiUrlString fqn
+
+                        HQ.HashOnly h ->
+                            withoutConstructorSuffix h
+
+                        HQ.HashQualified _ h ->
+                            withoutConstructorSuffix h
             in
-            [ Reference.toApiUrlString ref ]
-                |> List.map stripConstructorPositionFromHash
+            [ refToString ref ]
                 |> List.map (string "names")
                 |> (\names -> GET { path = [ "getDefinition" ], queryParams = names ++ perspectiveToQueryParams perspective })