Skip to content

fix: add List, Dict, Tuple and NamedTuple to the GenericDType bound #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: add List, Dict, Tuple and NamedTuple to the GenericDType bound #1556

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
25d29e6
fix: add List, Dict, Tuple and NamedTuple to the GenericDType bound
Apr 4, 2024
fd0f5df
chore: fix linter rules
Apr 4, 2024
8ab65a5
chore: apply formatting
Apr 4, 2024
0618909
add tests for complex python types
Apr 9, 2024
a48b798
fix: formatting
Apr 15, 2024
bd80139
Merge branch 'main' into main
cosmicBboy Apr 19, 2024
370086c
fix: use List, Dict and Tuple for python 3.8
Apr 20, 2024
9dc8ed5
Merge branch 'main' into main
cosmicBboy Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion pandera/typing/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,21 @@
"""Common typing functionality."""

# pylint:disable=abstract-method,too-many-ancestors,invalid-name

import inspect
from typing import TYPE_CHECKING, Any, Generic, Optional, Type, TypeVar, Union
from typing import (
TYPE_CHECKING,
Any,
Generic,
Optional,
Type,
TypeVar,
Union,
List,
Dict,
Tuple,
NamedTuple,
)

import pandas as pd
import typing_inspect
Expand Down Expand Up @@ -59,6 +72,10 @@
int,
str,
float,
List[Any],
Dict[Any, Any],
Tuple[Any],
NamedTuple,
Copy link
Author

@sam-goodwin sam-goodwin Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, I can't make the type parameters more precise?

Copy link
Author

@sam-goodwin sam-goodwin Apr 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cosmicBboy I think this change is ready to go, LMK if you see any issue with leaving these types wide.

Outstanding question is whether NamedTuple belongs there though.

Copy link
Collaborator

@cosmicBboy cosmicBboy Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you spot-check this with mypy?

NamedTuple should be fine here

Copy link
Author

@sam-goodwin sam-goodwin Apr 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think I've patched the MyPy problems:

> pre-commit run mypy --all-files
mypy.....................................................................Passed
- hook id: mypy
- duration: 2.27s

Success: no issues found in 180 source files

pd.core.dtypes.base.ExtensionDtype,
Bool,
Date,
Expand Down Expand Up @@ -101,6 +118,10 @@
int,
str,
float,
List[Any],
Dict[Any, Any],
Tuple[Any],
NamedTuple,
pd.core.dtypes.base.ExtensionDtype,
Bool,
Date,
Expand Down