-
Notifications
You must be signed in to change notification settings - Fork 237
Align DateError with DateFromFieldsError
#7137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
310e2bc to
d31c33f
Compare
sffc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not aligned on this, as discussed in the issue.
bff797b to
6f2426d
Compare
c62e8b3 to
5b17987
Compare
|
As it stands this is a breaking change, yes? |
|
no |
|
Ah, I see, UnknownMonthCode is still around. There is a little bit of concern around splitting the error variants but I don't really think matching on these variants is that common. I like this. I'm pretty ambivalent on the "nested RangeError or struct variant" thing, our design here has some mistakes but overall this is an extremely minor aspect of the API. |
|
I'm against adding new variants to And my position on the nested RangeError hasn't changed since last discussed in #7010. |
#7010
Adds
DateError::MonthCodeNotInCalendar,DateError::MonthCodeNotInYear, docs, and flattensDateFromFieldsError::Range