Skip to content

Requires GITHUB_TOKEN even if not needed #74

@xendk

Description

@xendk

Was setting up undercover with Eldev and CodeCov, and it failed in GitHub Actions with:

Error: (error "UNDERCOVER: Failed to detect Coveralls service_name")

It seems that undercover-coveralls--update-report-with-env expects either COVERALLS_REPO_TOKEN or GITHUB_TOKEN to be set, in order to set the service_name to either github or undercover-github-actions.

It's not entirely clear what's going on here, but making some guesses, wouldn't

(cond
 ((getenv "COVERALLS_REPO_TOKEN")
  "undercover-github-actions")
 (t
  "github"))

Be more appropriate? As far as I can tell, CodeCov doesn't use the token, in fact setting GITHUB_TOKEN to any value on the step that runs undercover seems to make it work just fine.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions