Ignoring all errors may hide important information from users / developers.
#45 fixes one instance of this (though, with-demoted-errors is not a complete fix).
As for the other remaining instance, the code seems to currently rely on it (i.e. errors occur as part of normal functioning). The code should be updated to handle error conditions explicitly in the place where they may occur; then, ignore-errors can be removed.
Ignoring all errors may hide important information from users / developers.
#45 fixes one instance of this (though,
with-demoted-errorsis not a complete fix).As for the other remaining instance, the code seems to currently rely on it (i.e. errors occur as part of normal functioning). The code should be updated to handle error conditions explicitly in the place where they may occur; then,
ignore-errorscan be removed.