Skip to content

Chap 5 suggestions #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salbert83 opened this issue Apr 11, 2021 · 1 comment · May be fixed by #50
Open

Chap 5 suggestions #122

salbert83 opened this issue Apr 11, 2021 · 1 comment · May be fixed by #50
Labels
medium-priority Grammar and typos errors. New feature

Comments

@salbert83
Copy link

  1. "bar(Binomial(N,p), ..." is used before StatsPlots is introduced.
  2. "p_ =plot(plots[1], plots[2], plots[3], plots[4], plots[5], plots[6], plots[7],plots[8], plots[9], ..." can be simplified to "p_ = plot(plots...," (splaying operator) . Similarly for p__.
  3. It seems the bandit example is the same as that in chapter 3.
@pefontana
Copy link
Collaborator

Hi @salbert83
Thanks again for the suggestions!
We will implement the 1 and 2 code suggestions!

The chapter 5 has problems in the web version, that is why it shows the bandit example is the same as that in chapter 3.
We will solve it in the next few days ,by the time,if you want to read the chapter you can download the GitHub repo and open the /05_prob_prog_intro/05_prob_prog_intro.jl file using Pluto.

Thanks again!

@pefontana pefontana added the medium-priority Grammar and typos errors. New feature label Apr 12, 2021
@pefontana pefontana linked a pull request Apr 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium-priority Grammar and typos errors. New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants