From faade06983223dd3bcb0ff558c2beca6c23883b8 Mon Sep 17 00:00:00 2001 From: Robert Zaremba Date: Tue, 28 Nov 2023 17:27:40 +0100 Subject: [PATCH 1/3] chore(oracle): update miss counter docs (#2337) * chore(oracle): update miss counter docs * Update x/oracle/README.md Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com> --------- Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com> --- RELEASE_NOTES.md | 2 ++ x/oracle/README.md | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 232592104a..513066070a 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -31,6 +31,8 @@ Highlights: Price Feeder `< umee/v2.3.0` is not compatible with Cosmos SDK v0.47. Validators must update to `umee/v2.3.0` or newer. +Please make sure your transactions are going through. If you see _out of gas_ in your transactions ([example](https://explorer.network.umee.cc/Canon-4/tx/74078158E2739CBF7EEA30D6BE673D207338E6686129717A4CED546F36F07CD7)). If you see out of gas errors, please increase `gas_adjustment` in your `price-feeder.toml`. + #### libwasmvm update Our dependencies have been updated. Now the binary requires `libwasmvm v1.5.0`. When you build the binary from source on the server machine you probably don't need any change. However when you download a binary from GitHub, or from other source, make sure you update the `/usr/lib/libwasmvm..so`. For example: diff --git a/x/oracle/README.md b/x/oracle/README.md index a1da963380..b545bb8718 100644 --- a/x/oracle/README.md +++ b/x/oracle/README.md @@ -50,7 +50,7 @@ Validators must first pre-commit to a set of exchange rates, then in the subsequ For each exchange rate, if the total voting power of submitted votes exceeds 50%, the weighted median of the votes is recorded on-chain as the effective rate for that denomination against USD for the following `VotePeriod` `P_t+1`. - Exchange rates receiving fewer than `VoteThreshold` total voting power have their exchange rates deleted from the store. + Exchange rates receiving fewer than `VoteThreshold` total voting power will not be updated (will keep the old price with the old timestamp). - Ballot Rewards @@ -78,8 +78,8 @@ The reward pool is not distributed all at once, but instead over a period of tim A `VotePeriod` during which either of the following events occur is considered a "miss": - The validator fails to submits a vote for **each and every** exchange rate specified in `AcceptList`. - - The validator fails to vote within the `reward band` around the weighted median for one or more denominations. +- Validators don't provide enough price votes for a given denom (ballot denom support is less than the required `VoteThreshold`) - **in that case all validators will receive a miss.** A `SlashWindow` is a window of time during which validators can miss votes. At the end of this period, the amount of misses are tallied and the proper reward or punishment is carried out. From c2985d3556ed5e39edbb4f1f13ef46384f84240d Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 30 Nov 2023 17:10:16 +0100 Subject: [PATCH 2/3] build(deps): Bump github.com/cometbft/cometbft from 0.37.2 to 0.37.4 (#2340) Bumps [github.com/cometbft/cometbft](https://github.com/cometbft/cometbft) from 0.37.2 to 0.37.4. - [Release notes](https://github.com/cometbft/cometbft/releases) - [Changelog](https://github.com/cometbft/cometbft/blob/main/CHANGELOG.md) - [Commits](https://github.com/cometbft/cometbft/compare/v0.37.2...v0.37.4) --- updated-dependencies: - dependency-name: github.com/cometbft/cometbft dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- go.mod | 2 +- go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index f79f4511ea..d597bf7c67 100644 --- a/go.mod +++ b/go.mod @@ -9,7 +9,7 @@ require ( cosmossdk.io/tools/rosetta v0.2.1 github.com/CosmWasm/wasmd v0.43.0 github.com/CosmWasm/wasmvm v1.5.0 - github.com/cometbft/cometbft v0.37.2 + github.com/cometbft/cometbft v0.37.4 github.com/cometbft/cometbft-db v0.8.0 github.com/cosmos/cosmos-proto v1.0.0-beta.2 // NOTE: v1.0.0-beta.2+ is not compatible with sdk v0.47 github.com/cosmos/cosmos-sdk v0.47.6 diff --git a/go.sum b/go.sum index 5da2401a35..ef2d33f581 100644 --- a/go.sum +++ b/go.sum @@ -444,8 +444,8 @@ github.com/codahale/hdrhistogram v0.0.0-20161010025455-3a0bb77429bd/go.mod h1:sE github.com/coinbase/kryptology v1.8.0/go.mod h1:RYXOAPdzOGUe3qlSFkMGn58i3xUA8hmxYHksuq+8ciI= github.com/coinbase/rosetta-sdk-go v0.7.9 h1:lqllBjMnazTjIqYrOGv8h8jxjg9+hJazIGZr9ZvoCcA= github.com/coinbase/rosetta-sdk-go v0.7.9/go.mod h1:0/knutI7XGVqXmmH4OQD8OckFrbQ8yMsUZTG7FXCR2M= -github.com/cometbft/cometbft v0.37.2 h1:XB0yyHGT0lwmJlFmM4+rsRnczPlHoAKFX6K8Zgc2/Jc= -github.com/cometbft/cometbft v0.37.2/go.mod h1:Y2MMMN//O5K4YKd8ze4r9jmk4Y7h0ajqILXbH5JQFVs= +github.com/cometbft/cometbft v0.37.4 h1:xyvvEqlyfK8MgNIIKVJaMsuIp03wxOcFmVkT26+Ikpg= +github.com/cometbft/cometbft v0.37.4/go.mod h1:Cmg5Hp4sNpapm7j+x0xRyt2g0juQfmB752ous+pA0G8= github.com/cometbft/cometbft-db v0.8.0 h1:vUMDaH3ApkX8m0KZvOFFy9b5DZHBAjsnEuo9AKVZpjo= github.com/cometbft/cometbft-db v0.8.0/go.mod h1:6ASCP4pfhmrCBpfk01/9E1SI29nD3HfVHrY4PG8x5c0= github.com/confio/ics23/go v0.9.0 h1:cWs+wdbS2KRPZezoaaj+qBleXgUk5WOQFMP3CQFGTr4= From b754f14f0504a4c2bc406ff0f4f71e6a2b15cf19 Mon Sep 17 00:00:00 2001 From: Adam Moser <63419657+toteki@users.noreply.github.com> Date: Thu, 30 Nov 2023 10:19:27 -0700 Subject: [PATCH 3/3] git diff file matching for go mod/sum (#2342) --- .github/workflows/govulncheck.yml | 1 + .github/workflows/simulations.yml | 4 ++++ .github/workflows/tests.yml | 4 ++++ 3 files changed, 9 insertions(+) diff --git a/.github/workflows/govulncheck.yml b/.github/workflows/govulncheck.yml index da3799250f..1a1c9c9e38 100644 --- a/.github/workflows/govulncheck.yml +++ b/.github/workflows/govulncheck.yml @@ -19,6 +19,7 @@ jobs: with: PATTERNS: | **/**.go + FILES: | go.mod go.sum - uses: golang/govulncheck-action@v1.0.1 diff --git a/.github/workflows/simulations.yml b/.github/workflows/simulations.yml index 5add21a779..f10dbcae82 100644 --- a/.github/workflows/simulations.yml +++ b/.github/workflows/simulations.yml @@ -34,6 +34,7 @@ jobs: with: PATTERNS: | **/**.go + FILES: | go.mod go.sum - uses: actions/setup-go@v4 @@ -58,6 +59,7 @@ jobs: with: PATTERNS: | **/**.go + FILES: | go.mod go.sum - uses: actions/setup-go@v4 @@ -87,6 +89,7 @@ jobs: with: PATTERNS: | **/**.go + FILES: | go.mod go.sum - uses: actions/setup-go@v4 @@ -115,6 +118,7 @@ jobs: with: PATTERNS: | **/**.go + FILES: | go.mod go.sum - uses: actions/setup-go@v4 diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 939476beaa..09daea7ae3 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -45,6 +45,7 @@ jobs: with: PATTERNS: | **/**.go + FILES: | go.mod go.sum - name: Setup go @@ -71,6 +72,7 @@ jobs: with: PATTERNS: | **/**.go + FILES: | go.mod go.sum - uses: actions/setup-go@v4 @@ -102,6 +104,7 @@ jobs: with: PATTERNS: | **/**.go + FILES: | go.mod go.sum - uses: actions/setup-go@v4 @@ -127,6 +130,7 @@ jobs: with: PATTERNS: | **/**.go + FILES: | go.mod go.sum