Skip to content

Commit 7c300fe

Browse files
committed
fix performance metrics relational query
1 parent 843f104 commit 7c300fe

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

src/app/(main)/websites/[websiteId]/sessions/SessionProfile.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
'use client';
2+
import { Avatar } from '@/components/common/Avatar';
3+
import { LoadingPanel } from '@/components/common/LoadingPanel';
4+
import { useMessages, useWebsiteSessionQuery } from '@/components/hooks';
25
import {
36
Button,
47
Column,
@@ -11,9 +14,6 @@ import {
1114
TextField,
1215
} from '@umami/react-zen';
1316
import { X } from 'lucide-react';
14-
import { Avatar } from '@/components/common/Avatar';
15-
import { LoadingPanel } from '@/components/common/LoadingPanel';
16-
import { useMessages, useWebsiteSessionQuery } from '@/components/hooks';
1717
import { SessionActivity } from './SessionActivity';
1818
import { SessionData } from './SessionData';
1919
import { SessionInfo } from './SessionInfo';
@@ -65,7 +65,7 @@ export function SessionProfile({
6565
<TabList>
6666
<Tab id="activity">{t(labels.activity)}</Tab>
6767
<Tab id="properties">{t(labels.properties)}</Tab>
68-
<Tab id="replays">{t(labels.replay)}</Tab>
68+
<Tab id="replays">{t(labels.replays)}</Tab>
6969
</TabList>
7070
<TabPanel id="activity">
7171
<SessionActivity

src/queries/sql/reports/getPerformanceMetrics.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import clickhouse from '@/lib/clickhouse';
2+
import { SESSION_COLUMNS } from '@/lib/constants';
23
import { CLICKHOUSE, PRISMA, runQuery } from '@/lib/db';
34
import prisma from '@/lib/prisma';
45
import type { QueryFilters } from '@/lib/types';
@@ -36,10 +37,10 @@ async function relationalQuery(
3637
): Promise<PerformanceMetricsData[]> {
3738
const { startDate, endDate, metric = 'lcp' } = parameters;
3839
const { rawQuery, parseFilters } = prisma;
39-
const { filterQuery, joinSessionQuery, cohortQuery, queryParams } = parseFilters({
40-
...filters,
41-
websiteId,
42-
});
40+
const { filterQuery, joinSessionQuery, cohortQuery, queryParams } = parseFilters(
41+
{ ...filters, websiteId },
42+
{ joinSession: SESSION_COLUMNS.includes(column) },
43+
);
4344

4445
return rawQuery(
4546
`

0 commit comments

Comments
 (0)