Improper data at end of slice

[frankplow]

The encoder does not seem to terminate slices properly. At the least, it misses the end_of_slice_one_bit syntax element but I think it might also miss the end_of_tile_one_bit syntax element, both of which are required by the specification. There seems to be some code which aims to write this data, but it is commented out:

uvg266/src/encoderstate.c

Lines 902 to 919 in 9c29121

	/*
	bool end_of_slice_segment_flag;
	if (state->encoder_control->cfg.slices & UVG_SLICES_WPP) {
	// Slice segments end after each WPP row.
	end_of_slice_segment_flag = lcu->last_column;
	}
	else if (state->encoder_control->cfg.slices & UVG_SLICES_TILES) {
	// Slices end after each tile.
	end_of_slice_segment_flag = lcu->last_column && lcu->last_row;
	}
	else {
	// Slice ends after the last row of the last tile.
	int last_tile_id = -1 + encoder->cfg.tiles_width_count * encoder->cfg.tiles_height_count;
	bool is_last_tile = state->tile->id == last_tile_id;
	end_of_slice_segment_flag = is_last_tile && lcu->last_column && lcu->last_row;
	}
	//uvg_cabac_encode_bin_trm(&state->cabac, end_of_slice_segment_flag);
	*/

[Eric3495]

邮件发到~~