Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure self._df_ret is defined before using or see alternatives #88

Open
GraysonBellamy opened this issue Mar 16, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@GraysonBellamy
Copy link
Contributor

🚀 Feature Request

Any function using self._df_ret needs to make sure it's defined first. See first lines of poll() function where it checks for self._df_format.

🔈 Motivation

Those functions will error out if that variable isn't defined.

🛰 Alternatives

We may just want to call the get_format function at the setup of the device or make some seperate function to convert floats.

📎 Additional context

image

@GraysonBellamy GraysonBellamy added the enhancement New feature or request label Mar 16, 2024
@GraysonBellamy
Copy link
Contributor Author

Currently have "if df_format is None: get_df_format()" at the beginning of all relevant functions. Will continue looking into if it is possible to initialize with a dataframe format

@GraysonBellamy
Copy link
Contributor Author

In the future want to put in init

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant