Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate setting "c" to None call #109

Open
GraysonBellamy opened this issue Mar 31, 2024 · 1 comment
Open

Eliminate setting "c" to None call #109

GraysonBellamy opened this issue Mar 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@GraysonBellamy
Copy link
Contributor

🚀 Feature Request

I believe we can eliminate this initial setting of "c" to None before reading. The initial use of this was so that we could break if the read timed out. As long as we return None through the read() function on timeout though we should be able to do without this.

🔈 Motivation

Eliminate needless setting of variable.

🛰 Alternatives

📎 Additional context

image

@GraysonBellamy GraysonBellamy added the enhancement New feature or request label Mar 31, 2024
@GraysonBellamy
Copy link
Contributor Author

Nevermind. This may not be true if the read_line() function times out before the read() function. Let's leave as-is for now because it's incredibly minor and maybe revisit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant