Exception handling for db.insert in bulkInsert. #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we throw an Exception when the date is not normalized I think we should handle the case where db.insert fails with the same severity. Currently it would mark the transaction as complete, meaning that if some items fails to be inserted, and are then read from the database, our recycler view will show the stored items and our user will see we are missing data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we throw an Exception when the date is not normalized I think we should handle the case where db.insert fails with the same severity.
Currently it would mark the transaction as complete, meaning that if some items fails to be inserted, and are then read from the database, our recycler view will show the stored items and our user will see we are missing data.