Skip to content

Commit 879b69e

Browse files
committed
Merge branch 'hotfix-487'
2 parents 78c2e86 + e3e62bb commit 879b69e

File tree

4 files changed

+13
-8
lines changed

4 files changed

+13
-8
lines changed

app/config/core.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@
342342
$CWL['applicationID'] = '';
343343
$CWL['applicationPassword'] = '';
344344

345-
define('IPEER_VERSION', '3.0.3');
345+
define('IPEER_VERSION', '3.0.4');
346346

347347

348348
/**

app/controllers/components/evaluation.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -285,10 +285,10 @@ function saveSimpleEvaluation($params=null, $groupEvent=null, $evaluationSubmiss
285285
}
286286

287287
// if no submission exists, create one
288-
$sub = $this->EvaluationSubmission->getEvalSubmissionByGrpEventIdSubmitter($grpEvent, $evaluator);
289-
if (empty($sub)) {
290-
$evaluationSubmission['EvaluationSubmission']['grp_event_id'] = $grpEvent;
291-
$evaluationSubmission['EvaluationSubmission']['event_id'] = $event;
288+
$sub = $this->EvaluationSubmission->getEvalSubmissionByGrpEventIdSubmitter($groupEvent['GroupEvent']['id'], $evaluator);
289+
if (empty($sub)) {
290+
$evaluationSubmission['EvaluationSubmission']['grp_event_id'] = $groupEvent['GroupEvent']['id'];
291+
$evaluationSubmission['EvaluationSubmission']['event_id'] = $groupEvent['GroupEvent']['event_id'];
292292
$evaluationSubmission['EvaluationSubmission']['submitter_id'] = $evaluator;
293293
// save evaluation submission
294294
$evaluationSubmission['EvaluationSubmission']['date_submitted'] = date('Y-m-d H:i:s');
@@ -1685,8 +1685,8 @@ function saveSurveyEvaluation($params=null)
16851685
$evaluationSubmission['EvaluationSubmission']['submitted'] = 1;
16861686
$evaluationSubmission['EvaluationSubmission']['date_submitted'] = date('Y-m-d H:i:s');
16871687
$evaluationSubmission['EvaluationSubmission']['event_id'] = $eventId;
1688-
}
1689-
1688+
}
1689+
16901690
$surveyInput = array();
16911691
$surveyInput['SurveyInput']['user_id'] = $userId;
16921692
$surveyInput['SurveyInput']['event_id'] = $eventId;

readme.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
iPeer 3.0.4
2+
---------------------------
3+
This is a maintenance release. It is recommended to upgrade to this version as it fixes a one critical bug.
4+
* Fix submissions for simple evaluation are not stored correctly
5+
16
iPeer 3.0.3
27
----------------------------
38
This is a maintenance release. It is recommended to upgrade to this version as it fixes a one critical bug.

version.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.0.3
1+
3.0.4

0 commit comments

Comments
 (0)