Skip to content

Commit 4eae6dd

Browse files
committed
Remove a filter in getMixevalResultDetail
The filter was based on primary role which is incorrect. It should be based on course role.
1 parent 9dceb35 commit 4eae6dd

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

app/controllers/components/evaluation.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -1078,9 +1078,9 @@ function getMixevalResultDetail($groupEventId, $groupMembers, $include)
10781078
$userId = isset($user['User'])? $user['User']['id'] : $user['id'];
10791079

10801080
// filter out the people who are not student, they should not get result
1081-
if ($user['Role'][0]['name'] != 'student') {
1082-
continue;
1083-
}
1081+
// if ($user['Role'][0]['name'] != 'student') {
1082+
// continue;
1083+
// }
10841084

10851085
// get the results for students
10861086
$evalResult[$userId] = $this->EvaluationMixeval->getResultsByEvaluatee($groupEventId, $userId, $include);

0 commit comments

Comments
 (0)