refactor: remove session deletion features

Author: tyql688

AGENTS.md

@@ -60,7 +60,7 @@ across `src-tauri/src/{providers,provider,indexer.rs,db,models.rs}` and
   for its own fields. Provider identity and metadata are bridged through a
   `Provider` enum + descriptor (`provider/`), so **adding a provider is a
   cross-layer change**, not just a parser: enum + catalog + Tauri asset-scope
-  allowlist + frontend provider type + theme/snapshot fallback + resume/trash
+  allowlist + frontend provider type + theme/snapshot fallback + resume
   behavior + tests. Exhaustive `match` on `Provider` makes the compiler surface
   most of these.
 - **Indexing** (`indexer.rs`) is incremental: providers short-circuit unchanged

README.md

@@ -38,7 +38,7 @@ Your data stays local. SessionView builds a local index for search and analytics
 - **Search without digging through folders**: global full-text search plus in-session find.
 - **Understand the work**: token timelines, tool-call mix, context/cache pressure, cost trends, and model breakdowns.
 - **Resume fast**: reopen a session in the matching terminal agent when the source tool supports it.
-- **Keep history tidy**: rename, favorite, export, trash/restore, hide noisy folders, and manage batches.
+- **Keep history organized**: rename, favorite, export, and hide noisy folders.
 - **Stay keyboard-friendly**: navigate tabs, panes, search, and common actions without leaving the keyboard.
 
 ## Session Analytics
@@ -68,7 +68,7 @@ When a tool exposes enough information, SessionView can also resume the selected
 Grab the latest build from [**Releases**](https://github.com/tyql688/sessionview/releases):
 
 | Platform | File |
-|----------|------|
+| ---------- | ------ |
 | macOS | `.dmg` |
 | Windows | `.exe` (NSIS installer) |
 | Linux | `.deb` / `.AppImage` |

README.zh-CN.md

@@ -38,7 +38,7 @@ AI 编程工具会在你的机器上留下很多有价值的上下文：决策
 - **不用翻目录也能搜索**：全局全文搜索，加上当前会话内查找。
 - **看懂一次工作的形状**：Token 时间线、工具调用分布、上下文/缓存压力、成本趋势和模型拆分。
 - **快速恢复现场**：源工具支持时，可以直接在对应终端代理中继续会话。
-- **整理历史**：重命名、收藏、导出、回收站/恢复、屏蔽吵闹目录和批量操作。
+- **整理历史**：重命名、收藏、导出和屏蔽吵闹目录。
 - **键盘友好**：标签页、分栏、搜索和常用动作都能用键盘完成。
 
 ## 会话分析
@@ -68,7 +68,7 @@ SessionView 当前读取 Claude Code、Codex CLI、Antigravity、Kimi Code、Cur
 从 [**Releases**](https://github.com/tyql688/sessionview/releases) 下载最新构建：
 
 | 平台 | 文件 |
-|------|------|
+| ------ | ------ |
 | macOS | `.dmg` |
 | Windows | `.exe`（NSIS 安装包） |
 | Linux | `.deb` / `.AppImage` |

src-tauri/src/commands/mod.rs

@@ -4,7 +4,6 @@ mod session_tail;
 mod sessions;
 mod settings;
 mod terminal;
-pub mod trash;
 mod usage;
 
 use std::collections::{HashMap, HashSet};
@@ -53,7 +52,6 @@ pub use search::*;
 pub use sessions::*;
 pub use settings::*;
 pub use terminal::*;
-pub use trash::*;
 pub use usage::*;
 
 pub(crate) fn load_session_detail_for_tests(

src-tauri/src/commands/sessions.rs

@@ -9,11 +9,11 @@ use crate::db::Database;
 use crate::error::{CommandError, CommandResult};
 use crate::models::{Message, Provider, SessionDetail, SessionMeta, TokenTotals};
 use crate::services::load_cancel;
+use crate::services::load_session_meta;
 use crate::services::session_view::{
     build_session_turn_outline, session_window_bounds, subagent_meta_title, with_load_guard,
     LoadRequest, SessionTurnOutline,
 };
-use crate::services::{load_session_meta, SessionLifecycleService};
 
 use super::session_tail::try_tail_fast_path;
 use super::AppState;
@@ -378,17 +378,6 @@ pub async fn get_child_session_counts(
     .map_err(CommandError::from)
 }
 
-#[tauri::command]
-pub async fn delete_session(session_id: String, state: State<'_, AppState>) -> CommandResult<()> {
-    let state = state.inner().clone();
-    tokio::task::spawn_blocking(move || {
-        SessionLifecycleService::new(&state.db).purge_session(&session_id)
-    })
-    .await
-    .context("task join error")?
-    .map_err(CommandError::from)
-}
-
 #[tauri::command]
 pub async fn rename_session(
     session_id: String,

src-tauri/src/commands/trash.rs

@@ -170,19 +170,6 @@ impl Database {
         Ok(out)
     }
 
-    pub(crate) fn count_sessions_for_source(
-        &self,
-        provider_key: &str,
-        source_path: &str,
-    ) -> Result<u64, rusqlite::Error> {
-        let conn = self.lock_read()?;
-        conn.query_row(
-            "SELECT COUNT(*) FROM sessions WHERE provider = ?1 AND source_path = ?2",
-            params![provider_key, source_path],
-            |row| row.get(0),
-        )
-    }
-
     pub(crate) fn provider_session_counts(&self) -> Result<HashMap<String, u64>, rusqlite::Error> {
         let conn = self.lock_read()?;
         let mut stmt = conn.prepare("SELECT provider, COUNT(*) FROM sessions GROUP BY provider")?;

src-tauri/src/db/queries/sessions.rs

@@ -221,10 +221,6 @@ fn should_delete_provider_snapshot(
     current_count <= 10 || (alive_count as f64 / current_count as f64) > 0.5
 }
 
-fn should_delete_source_snapshot(current_count: u64, scan_count: u64) -> bool {
-    scan_count == 0 || current_count <= 10 || (scan_count as f64 / current_count as f64) > 0.5
-}
-
 impl Database {
     pub fn sync_provider_snapshot(
         &self,
@@ -279,43 +275,6 @@ impl Database {
         })
     }
 
-    pub(crate) fn sync_source_snapshot(
-        &self,
-        provider: &Provider,
-        source_path: &str,
-        sessions: &[ParsedSession],
-    ) -> Result<(), rusqlite::Error> {
-        let provider_key = provider.key().to_string();
-        let ids: HashSet<String> = sessions
-            .iter()
-            .map(|parsed| parsed.meta.id.clone())
-            .collect();
-
-        let current_count = self.count_sessions_for_source(&provider_key, source_path)?;
-        let scan_count = sessions.len() as u64;
-        // For single-source sync, scan_count==0 is a valid signal (file deleted).
-        // Only apply ratio guard when both sides are non-zero.
-        let should_delete = should_delete_source_snapshot(current_count, scan_count);
-
-        if !should_delete {
-            log::warn!(
-                "provider {provider:?} source {source_path:?} scan returned {scan_count} sessions but DB has {current_count}, skipping destructive sync");
-        }
-
-        self.with_transaction(|conn| {
-            upsert_parsed_sessions_on(conn, sessions)?;
-
-            if should_delete {
-                delete_missing_sessions_for_source(conn, &provider_key, source_path, &ids)?;
-                conn.execute(
-                    "DELETE FROM favorites WHERE session_id NOT IN (SELECT id FROM sessions)",
-                    [],
-                )?;
-            }
-            Ok(())
-        })
-    }
-
     pub(crate) fn rename_session(&self, id: &str, new_title: &str) -> Result<(), rusqlite::Error> {
         let conn = self.lock_write()?;
         conn.execute(
@@ -365,16 +324,6 @@ impl Database {
         Ok(())
     }
 
-    /// Delete this session and all its children from DB.
-    pub(crate) fn delete_session(&self, id: &str) -> Result<(), rusqlite::Error> {
-        let conn = self.lock_write()?;
-        conn.execute("DELETE FROM favorites WHERE session_id IN (SELECT id FROM sessions WHERE parent_id = ?1)", params![id])?;
-        conn.execute("DELETE FROM sessions WHERE parent_id = ?1", params![id])?;
-        conn.execute("DELETE FROM favorites WHERE session_id = ?1", params![id])?;
-        conn.execute("DELETE FROM sessions WHERE id = ?1", params![id])?;
-        Ok(())
-    }
-
     /// Replace all token stats for a session. Called during indexing.
     /// Deletes existing rows first, then inserts new per-(date, model) aggregates.
     /// Also refreshes the denormalized totals on `sessions` so list/search

src-tauri/src/db/sync.rs

@@ -68,17 +68,6 @@ fn provider_snapshot_delete_guard_counts_preserved_sources_as_alive() {
     ));
 }
 
-#[test]
-fn source_snapshot_delete_guard_treats_empty_scan_as_deleted_file() {
-    assert!(super::should_delete_source_snapshot(100, 0));
-}
-
-#[test]
-fn source_snapshot_delete_guard_uses_ratio_for_non_empty_scans() {
-    assert!(super::should_delete_source_snapshot(100, 51));
-    assert!(!super::should_delete_source_snapshot(100, 50));
-}
-
 #[test]
 fn replace_token_stats_clears_existing_rows_when_empty() {
     let dir = TempDir::new().unwrap();

src-tauri/src/db/sync/tests.rs

@@ -130,14 +130,9 @@ impl Indexer {
         let pricing_catalog = self.cached_pricing_catalog();
         let now_millis = epoch_millis(SystemTime::now())?;
 
-        let excluded = crate::trash_state::shared_deleted_ids();
         let provider_refs = self.selected_providers(filter);
-        let works = self.collect_provider_work(
-            &provider_refs,
-            pricing_catalog.as_ref(),
-            &excluded,
-            force_parse,
-        )?;
+        let works =
+            self.collect_provider_work(&provider_refs, pricing_catalog.as_ref(), force_parse)?;
 
         // Phase 2 (sequential, DB writer): commit each provider's snapshot.
         // SQLite has a single writer mutex; serializing here avoids contention
@@ -206,7 +201,6 @@ impl Indexer {
         &self,
         providers: &[&dyn SessionProvider],
         pricing_catalog: Option<&PricingCatalog>,
-        excluded: &HashSet<String>,
         force_parse: bool,
     ) -> ServiceResult<Vec<ProviderWork>> {
         // Phase 1 (parallel, CPU/IO): scan each provider's files and compute
@@ -215,17 +209,14 @@ impl Indexer {
         // scan), so providers don't share state and can run in parallel.
         providers
             .par_iter()
-            .map(|provider| {
-                self.scan_provider_work(*provider, pricing_catalog, excluded, force_parse)
-            })
+            .map(|provider| self.scan_provider_work(*provider, pricing_catalog, force_parse))
             .collect()
     }
 
     fn scan_provider_work(
         &self,
         provider: &dyn SessionProvider,
         pricing_catalog: Option<&PricingCatalog>,
-        excluded: &HashSet<String>,
         force_parse: bool,
     ) -> ServiceResult<ProviderWork> {
         let provider_kind = provider.provider();
@@ -250,13 +241,8 @@ impl Indexer {
         let outcome = provider.scan_incremental(&known).map_err(|e| {
             ServiceError::ScanProvider(provider_kind.key().to_string(), e.to_string())
         })?;
-        let mut sessions = outcome.parsed;
+        let sessions = outcome.parsed;
         let unchanged_source_paths = outcome.unchanged_source_paths;
-
-        if !excluded.is_empty() {
-            sessions.retain(|session| !excluded.contains(&session.meta.id));
-        }
-
         let stats_batch = build_token_stats_batch(provider, &sessions, pricing_catalog);
 
         Ok(ProviderWork {
@@ -319,7 +305,7 @@ impl Indexer {
         }
         self.db
             .set_meta("usage_last_refreshed_at", &chrono::Utc::now().to_rfc3339())
-            .map_err(|e| ServiceError::StoreUsageLastRefreshed(e.to_string()))?;
+            .map_err(|error| ServiceError::StoreUsageLastRefreshed(error.to_string()))?;
         Ok(())
     }