Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Request: Ability to Set Height to "Auto" #17

Open
actuallyReallyAlex opened this issue Nov 20, 2018 · 2 comments
Open

Feat Request: Ability to Set Height to "Auto" #17

actuallyReallyAlex opened this issue Nov 20, 2018 · 2 comments

Comments

@actuallyReallyAlex
Copy link

I know that you can set the width and height by specifying them as options, but if you don't already know the height of the page, it would be nice to add an option to have that calculated for you.

Something like tlapse localhost:3000 -v 1300 x auto or similar.

@typicode
Copy link
Owner

Did a quick search in https://github.com/GoogleChrome/puppeteer/blob/v1.10.0/docs/api.md but couldn't find anything. If there is actually, yes, why not, PR welcome :)

I wonder also if having screenshots with different height wouldn't make generating GIFs more complicated?

@actuallyReallyAlex
Copy link
Author

Yeah, you might be right about it being more complicated. Right now I just have the height to some ridiculous number, so that I can just go and crop it down later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants