Skip to content

Commit ea960c7

Browse files
Fix arguments passed to array-type (#334)
* Add test for arguments passed to array-type See https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/array-type.md * Fix arguments passed to array-type
1 parent 7e8b6ba commit ea960c7

File tree

2 files changed

+46
-1
lines changed

2 files changed

+46
-1
lines changed

src/rules/converters/array-type.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
import { RuleConverter } from "../converter";
22

3-
export const convertArrayType: RuleConverter = () => {
3+
export const convertArrayType: RuleConverter = tslintRule => {
44
return {
55
rules: [
66
{
7+
...(tslintRule.ruleArguments.length > 0 && {
8+
ruleArguments: [{ default: tslintRule.ruleArguments[0] }],
9+
}),
710
ruleName: "@typescript-eslint/array-type",
811
},
912
],

src/rules/converters/tests/array-type.test.ts

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,46 @@ describe(convertArrayType, () => {
1414
],
1515
});
1616
});
17+
test("conversion with argument array-simple", () => {
18+
const result = convertArrayType({
19+
ruleArguments: ["array-simple"],
20+
});
21+
22+
expect(result).toEqual({
23+
rules: [
24+
{
25+
ruleName: "@typescript-eslint/array-type",
26+
ruleArguments: [{ default: "array-simple" }],
27+
},
28+
],
29+
});
30+
});
31+
test("conversion with argument generic", () => {
32+
const result = convertArrayType({
33+
ruleArguments: ["generic"],
34+
});
35+
36+
expect(result).toEqual({
37+
rules: [
38+
{
39+
ruleName: "@typescript-eslint/array-type",
40+
ruleArguments: [{ default: "generic" }],
41+
},
42+
],
43+
});
44+
});
45+
test("conversion with argument simple", () => {
46+
const result = convertArrayType({
47+
ruleArguments: ["simple"],
48+
});
49+
50+
expect(result).toEqual({
51+
rules: [
52+
{
53+
ruleName: "@typescript-eslint/array-type",
54+
ruleArguments: [{ default: "simple" }],
55+
},
56+
],
57+
});
58+
});
1759
});

0 commit comments

Comments
 (0)