Skip to content

Commit daee715

Browse files
authored
Add codelyzer no-conflicting-lifecycle converter (#538)
1 parent e812c84 commit daee715

File tree

3 files changed

+32
-0
lines changed

3 files changed

+32
-0
lines changed
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import { RuleConverter } from "../../converter";
2+
3+
export const convertNoConflictingLifecycle: RuleConverter = () => {
4+
return {
5+
rules: [
6+
{
7+
ruleName: "@angular-eslint/no-conflicting-lifecycle",
8+
},
9+
],
10+
plugins: ["@angular-eslint/eslint-plugin"],
11+
};
12+
};
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import { convertNoConflictingLifecycle } from "../no-conflicting-lifecycle";
2+
3+
describe(convertNoConflictingLifecycle, () => {
4+
test("conversion without arguments", () => {
5+
const result = convertNoConflictingLifecycle({
6+
ruleArguments: [],
7+
});
8+
9+
expect(result).toEqual({
10+
rules: [
11+
{
12+
ruleName: "@angular-eslint/no-conflicting-lifecycle",
13+
},
14+
],
15+
plugins: ["@angular-eslint/eslint-plugin"],
16+
});
17+
});
18+
});

src/rules/rulesConverters.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ import { convertNoHostMetadataProperty } from "./converters/codelyzer/no-host-me
151151
import { convertNoInputPrefix } from "./converters/codelyzer/no-input-prefix";
152152
import { convertNoInputRename } from "./converters/codelyzer/no-input-rename";
153153
import { convertNoInputsMetadataProperty } from "./converters/codelyzer/no-inputs-metadata-property";
154+
import { convertNoConflictingLifecycle } from "./converters/codelyzer/no-conflicting-lifecycle";
154155

155156
/**
156157
* Keys TSLint rule names to their ESLint rule converters.
@@ -207,6 +208,7 @@ export const rulesConverters = new Map([
207208
["no-bitwise", convertNoBitwise],
208209
["no-boolean-literal-compare", convertNoBooleanLiteralCompare],
209210
["no-conditional-assignment", convertNoConditionalAssignment],
211+
["no-conflicting-lifecycle", convertNoConflictingLifecycle],
210212
["no-consecutive-blank-lines", convertNoConsecutiveBlankLines],
211213
["no-console", convertNoConsole],
212214
["no-constant-condition", convertNoConstantCondition],

0 commit comments

Comments
 (0)