Switched no-console output from blacklist to whitelist (#235)

typescript-eslint · Oct 10, 2019 · 319e0b1 · 319e0b1
1 parent bd694e7
commit 319e0b1
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/rules/converters/no-console.ts b/src/rules/converters/no-console.ts
@@ -5,7 +5,14 @@ export const convertNoConsole: RuleConverter = tslintRule => {
         rules: [
             {
                 ...(tslintRule.ruleArguments.length !== 0 && {
-                    ruleArguments: [{ allow: tslintRule.ruleArguments }],
+                    notices: ["Custom console methods, if they exist, will no longer be allowed."],
+                    ruleArguments: [
+                        {
+                            allow: Object.keys(console).filter(
+                                method => !tslintRule.ruleArguments.includes(method),
+                            ),
+                        },
+                    ],
                 }),
                 ruleName: "no-console",
             },

diff --git a/src/rules/converters/tests/no-console.test.ts b/src/rules/converters/tests/no-console.test.ts
@@ -1,5 +1,15 @@
 import { convertNoConsole } from "../no-console";
 
+const consoleKeysExcluding = (...keys: string[]) => {
+    const knownConsoleKeys = new Set(Object.keys(console));
+
+    for (const key of keys) {
+        knownConsoleKeys.delete(key);
+    }
+
+    return Array.from(knownConsoleKeys);
+};
+
 describe(convertNoConsole, () => {
     test("conversion without arguments", () => {
         const result = convertNoConsole({
@@ -23,7 +33,8 @@ describe(convertNoConsole, () => {
         expect(result).toEqual({
             rules: [
                 {
-                    ruleArguments: [{ allow: ["info", "log"] }],
+                    notices: ["Custom console methods, if they exist, will no longer be allowed."],
+                    ruleArguments: [{ allow: consoleKeysExcluding("info", "log") }],
                     ruleName: "no-console",
                 },
             ],