Corrected no-import-side-effect output rule (#271)

typescript-eslint · Nov 16, 2019 · 1aabfa2 · 1aabfa2
1 parent d81d262
commit 1aabfa2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/rules/converters/no-import-side-effect.ts b/src/rules/converters/no-import-side-effect.ts
@@ -4,10 +4,11 @@ export const convertNoImportSideEffect: RuleConverter = tsLintRule => {
     return {
         rules: [
             {
-                ruleName: "no-import-side-effect",
+                plugins: ["eslint-plugin-import"],
+                ruleName: "import/no-unassigned-import",
                 ...(tsLintRule.ruleArguments.length !== 0 && {
                     notices: [
-                        "ESLint's no-import-side-effect now accepts a glob pattern for ignores; you'll need to manually convert your ignore-module settings.",
+                        "ESLint's import/no-unassigned-import now accepts a glob pattern for ignores; you'll need to manually convert your ignore-module settings.",
                     ],
                 }),
             },

diff --git a/src/rules/converters/tests/no-import-side-effect.test.ts b/src/rules/converters/tests/no-import-side-effect.test.ts
@@ -9,7 +9,8 @@ describe(convertNoImportSideEffect, () => {
         expect(result).toEqual({
             rules: [
                 {
-                    ruleName: "no-import-side-effect",
+                    plugins: ["eslint-plugin-import"],
+                    ruleName: "import/no-unassigned-import",
                 },
             ],
         });
@@ -23,10 +24,11 @@ describe(convertNoImportSideEffect, () => {
         expect(result).toEqual({
             rules: [
                 {
-                    ruleName: "no-import-side-effect",
+                    plugins: ["eslint-plugin-import"],
                     notices: [
-                        "ESLint's no-import-side-effect now accepts a glob pattern for ignores; you'll need to manually convert your ignore-module settings.",
+                        "ESLint's import/no-unassigned-import now accepts a glob pattern for ignores; you'll need to manually convert your ignore-module settings.",
                     ],
+                    ruleName: "import/no-unassigned-import",
                 },
             ],
         });