Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format email message. #33

Open
sroutier opened this issue Jun 28, 2016 · 12 comments
Open

Format email message. #33

sroutier opened this issue Jun 28, 2016 · 12 comments

Comments

@sroutier
Copy link
Contributor

Hello,

Thanks for this great package.

Do you know of a good way to format the email message that is sent?
In the "Changing the text" section of your README, you show us how to do some formatting and how to add details but the HTML formatting is not retained.
Ideally LERN would make use and publish templates that could be customized.

Any thoughts?

Cheers.
/S

@tylercd100
Copy link
Owner

Hey Sebastian, thanks for reaching out. I like the idea of using templates
for LERN. Let me get back to you after I've done some digging through the
code.

On Mon, Jun 27, 2016, 7:01 PM Sebastien Routier [email protected]
wrote:

Hello,

Thanks for this great package.

Do you know of a good way to format the email message that is sent?
In the "Changing the text" section of your README, you show us how to do
some formatting and how to add details but the HTML formatting is not
retained.
Ideally LERN would make use and publish templates that could be customized.

Any thoughts?

Cheers.
/S


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#33, or mute the thread
https://github.com/notifications/unsubscribe/AEUA8rfPu7wnk15Qn93ebp3AEKAW_oU4ks5qQHJZgaJpZM4I_pa7
.

@tylercd100
Copy link
Owner

Hey @sroutier I just saw the package you are working on. What an honor! :)

I'll try an make sure I get this done this week

@sroutier
Copy link
Contributor Author

Thanks, would be great if email templates could be supported. It would add some polish and customizations.
Could not have done it without the great packages created and open-sourced by the community like yourself.

Cheers.
/S

@eleftrik
Copy link

I agree with @sroutier, using an e-mail template would be great.

@tylercd100
Copy link
Owner

Hey @sroutier and @eleftrik. I have released version 3.6.5 which allows for html in emails.

I am still going to keep this issue open because I think templates is a great idea. I do however want to see how I can utilize Laravel 5.3's new Email and Notification functionality to see if it would benefit templates in a LERN v4.0 release.

@sroutier
Copy link
Contributor Author

That is great Tyler.
I will look at it ASAP.
Thanks a lot.
/S

On Tue, Aug 30, 2016 at 6:05 PM, Tyler Arbon [email protected]
wrote:

Hey @sroutier https://github.com/sroutier and @eleftrik
https://github.com/eleftrik. I have released version 3.6.5
https://github.com/tylercd100/lern/releases/tag/3.6.5 which allows for
html in emails.

I am still going to keep this issue open because I think templates is a
great idea. I do however want to see how I can utilize Laravel 5.3's new
Email and Notification functionality to see if it would benefit templates
in a LERN v4.0 release.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#33 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC30Fv_F6iqNnNNaTWBWTQ8xBmwirxeTks5qlKlHgaJpZM4I_pa7
.

@eleftrik
Copy link

Thank you @tylercd100, I will try ASAP

@eleftrik
Copy link

@tylercd100, I tried to use HTML, but I'm still receiving emails with expanded tags.
Can you please share an example?

@tylercd100
Copy link
Owner

tylercd100 commented Nov 28, 2016

@eleftrik @sroutier I got blade templates working with LERN

Check out the README for the latest version.
You will also need to run this line in the terminal if you want to use the default blade template

php artisan vendor:publish --provider="Tylercd100\LERN\LERNServiceProvider"

@tylercd100
Copy link
Owner

@eleftrik It looks like SMTP is not properly setting the email type to HTML for the email, I will get this fixed as soon as I can

@eleftrik
Copy link

@eleftrik It looks like SMTP is not properly setting the email type to HTML for the email, I will get this fixed as soon as I can

Hi @tylercd100, was this fixed? I tried to upgrade to version 3.8.2, but I'm still receiving text only e-mails, with no line breaks and no HTML format.

Thank you

@eleftrik
Copy link

eleftrik commented Jul 11, 2017

Now it works! Sorry, I forgot update my config file, adding 'view' => 'exceptions.default',

One last issue: when I receive email, they always start with something like

[2017-07-11 14:55:01] Tylercd100\LERN.CRITICAL:

..and end with two empty arrays: [] []

In resources/exceptions/default.blade.php I'm not priting such arrays.

@tylercd100, have you any suggestion?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants