Skip to content

Commit 9c6e01f

Browse files
mosesnjenkins
authored and
jenkins
committed
Revert "3rdparty: jackson upgrade to 2.13.0"
Problem 2.13.0 introduced a regression, where they were double-serializing. We're worried that this will lead to a substantial performance regression. Github ticket: FasterXML/jackson-databind#3308 Solution This reverts commit e27353b784543196b9f5fd572110e4b4fe04f4c4. JIRA Issues: CSL-11459 Differential Revision: https://phabricator.twitter.biz/D780287
1 parent 1322d86 commit 9c6e01f

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

CHANGELOG.rst

-7
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,11 @@ Note that ``PHAB_ID=#`` and ``RB_ID=#`` correspond to associated messages in com
77
Unreleased
88
----------
99

10-
Breaking API Changes
11-
~~~~~~~~~~~~~~~~~~~~
12-
13-
* util-jackson: The error message when failing to deserialize a character now correctly prints the non-character string. ``PHAB_ID=D744627``
14-
1510
Runtime Behavior Changes
1611
~~~~~~~~~~~~~~~~~~~~~~~~
1712

1813
* util-cache: Update Caffeine cache library to version 2.9.2 ``PHAB_ID=D771893``
1914

20-
* util: Bump version of Jackson to 2.13.0. ``PHAB_ID=D744627``
21-
2215
21.10.0
2316
-------
2417

build.sbt

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Global / excludeLintKeys += scalacOptions // might be actually unused in util-do
77
val releaseVersion = "21.11.0-SNAPSHOT"
88

99
val slf4jVersion = "1.7.30"
10-
val jacksonVersion = "2.13.0"
10+
val jacksonVersion = "2.11.4"
1111
val mockitoVersion = "3.3.3"
1212
val mockitoScalaVersion = "1.14.8"
1313

util-jackson/src/test/scala/com/twitter/util/jackson/ScalaObjectMapperTest.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -823,7 +823,7 @@ class ScalaObjectMapperTest
823823
|}
824824
""".stripMargin,
825825
withErrors = Seq(
826-
"c: '-1' is not a valid Character"
826+
"c: '' is not a valid Character"
827827
)
828828
)
829829
}

0 commit comments

Comments
 (0)