minor #4446 Improve YieldReady support docs (fabpot)

This PR was merged into the 3.x branch.

Discussion
----------

Improve YieldReady support docs

Refs #4428

Commits
-------

9d9c9d8 Improve YieldReady support docs

Author: fabpot

doc/deprecated.rst

@@ -183,6 +183,12 @@ Nodes
   Twig 3.15; use ``Twig\Node\Expression\Variable\AssignContextVariable``
   instead.
 
+* Node implementations that use ``echo`` or ``print`` should use ``yield``
+  instead; all Node implementations should use the
+  ``#[\Twig\Attribute\YieldReady]`` attribute on their class once they've been
+  made ready for ``yield``; the ``use_yield`` Environment option can be turned
+  on when all nodes use the ``#[\Twig\Attribute\YieldReady]`` attribute.
+
 Node Visitors
 -------------
 

src/Compiler.php

@@ -74,7 +74,7 @@ public function compile(Node $node, int $indentation = 0)
             $node->compile($this);
 
             if ($this->didUseEcho) {
-                trigger_deprecation('twig/twig', '3.9', 'Using "%s" is deprecated, use "yield" instead in "%s", then flag the class with #[YieldReady].', $this->didUseEcho, \get_class($node));
+                trigger_deprecation('twig/twig', '3.9', 'Using "%s" is deprecated, use "yield" instead in "%s", then flag the class with #[\Twig\Attribute\YieldReady].', $this->didUseEcho, \get_class($node));
             }
 
             return $this;
@@ -99,7 +99,7 @@ public function subcompile(Node $node, bool $raw = true)
             $node->compile($this);
 
             if ($this->didUseEcho) {
-                trigger_deprecation('twig/twig', '3.9', 'Using "%s" is deprecated, use "yield" instead in "%s", then flag the class with #[YieldReady].', $this->didUseEcho, \get_class($node));
+                trigger_deprecation('twig/twig', '3.9', 'Using "%s" is deprecated, use "yield" instead in "%s", then flag the class with #[\Twig\Attribute\YieldReady].', $this->didUseEcho, \get_class($node));
             }
 
             return $this;

src/NodeVisitor/YieldNotReadyNodeVisitor.php

@@ -41,7 +41,7 @@ public function enterNode(Node $node, Environment $env): Node
                 throw new \LogicException(\sprintf('You cannot enable the "use_yield" option of Twig as node "%s" is not marked as ready for it; please make it ready and then flag it with the #[YieldReady] attribute.', $class));
             }
 
-            trigger_deprecation('twig/twig', '3.9', 'Twig node "%s" is not marked as ready for using "yield" instead of "echo"; please make it ready and then flag it with the #[YieldReady] attribute.', $class);
+            trigger_deprecation('twig/twig', '3.9', 'Twig node "%s" is not marked as ready for using "yield" instead of "echo"; please make it ready and then flag it with the #[\Twig\Attribute\YieldReady] attribute.', $class);
         }
 
         return $node;

tests/EnvironmentTest.php

@@ -445,11 +445,11 @@ public function testLegacyEchoingNode()
 
         if ($twig->useYield()) {
             $this->expectException(SyntaxError::class);
-            $this->expectExceptionMessage('An exception has been thrown during the compilation of a template ("You cannot enable the "use_yield" option of Twig as node "Twig\Tests\EnvironmentTest_LegacyEchoingNode" is not marked as ready for it; please make it ready and then flag it with the #[YieldReady] attribute.") in "echo_bar".');
+            $this->expectExceptionMessage('An exception has been thrown during the compilation of a template ("You cannot enable the "use_yield" option of Twig as node "Twig\Tests\EnvironmentTest_LegacyEchoingNode" is not marked as ready for it; please make it ready and then flag it with the #[\Twig\Attribute\YieldReady] attribute.") in "echo_bar".');
         } else {
             $this->expectDeprecation(<<<'EOF'
-Since twig/twig 3.9: Twig node "Twig\Tests\EnvironmentTest_LegacyEchoingNode" is not marked as ready for using "yield" instead of "echo"; please make it ready and then flag it with the #[YieldReady] attribute.
-  Since twig/twig 3.9: Using "echo" is deprecated, use "yield" instead in "Twig\Tests\EnvironmentTest_LegacyEchoingNode", then flag the class with #[YieldReady].
+Since twig/twig 3.9: Twig node "Twig\Tests\EnvironmentTest_LegacyEchoingNode" is not marked as ready for using "yield" instead of "echo"; please make it ready and then flag it with the #[\Twig\Attribute\YieldReady] attribute.
+  Since twig/twig 3.9: Using "echo" is deprecated, use "yield" instead in "Twig\Tests\EnvironmentTest_LegacyEchoingNode", then flag the class with #[\Twig\Attribute\YieldReady].
 EOF
             );
         }