Skip to content

Inconsistent naming of model name field (model, modelName, chatModelName) #16

@jhrcek

Description

@jhrcek

It would be great if we could unify the name of the fields representing model name (Text).
It's somewhat annoying to change the field name when switching between e.g. Chat vs Generate.
IMO it would make sense to use the same field name everywhere, since they represent the same thing.

At this point there are multiple places that use model, while others use modelName or chatModelName.
See different usages in haddocks:
https://hackage-content.haskell.org/package/ollama-haskell-0.2.0.0/docs/doc-index-M.html

Would you be ok with unifying these? I can open PR unifying these. But need your input on which of the 2 would be preferable to use?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions