Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont throw / ignore node errors #144

Open
2 of 3 tasks
turtle0x1 opened this issue Jan 24, 2020 · 0 comments
Open
2 of 3 tasks

Dont throw / ignore node errors #144

turtle0x1 opened this issue Jan 24, 2020 · 0 comments

Comments

@turtle0x1
Copy link
Owner

turtle0x1 commented Jan 24, 2020

Generally the node script is ... lacking in thought.

Ive done some of the suggested things, but as node really isn't that interesting to me at that point, im simply just going to do it ... later

Need to be done

  • Dont throw errors, its bad practice & kills the script + pm2 has to restart it (if you do pm2 list you will see a high number of restarts)

  • Cache read host certificates

  • Cache operations web-sockets & prevent opening duplicates

Maybe

  • use the fs.readFile (reading a file is a pretty sync job, im not sure I agree with this, but if someone else wants to do it, feel free)
@turtle0x1 turtle0x1 added this to the 0.8.0 milestone Apr 12, 2020
@turtle0x1 turtle0x1 changed the title Node: Code Review Remaining Technical debt Dont throw / ignore node errors Apr 13, 2020
@turtle0x1 turtle0x1 modified the milestones: 0.8.0, Later Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant