Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse multi-line statements correctly #50

Open
luisfvieirasilva opened this issue Mar 7, 2023 · 1 comment · May be fixed by #85
Open

Parse multi-line statements correctly #50

luisfvieirasilva opened this issue Mar 7, 2023 · 1 comment · May be fixed by #85
Labels
bug Something isn't working

Comments

@luisfvieirasilva
Copy link

Our multi-line needs a parser (that can parse incomplete SQL statements) to verify when a statement really ended. Right now, it'll break if I try to insert something like this:

→  select "hello;
@luisfvieirasilva luisfvieirasilva added the bug Something isn't working label Mar 7, 2023
@luisfvieirasilva luisfvieirasilva self-assigned this Mar 9, 2023
@luisfvieirasilva
Copy link
Author

Thinking about this, I think now that's best just check if semi-column (;) is inside a string or not

@luisfvieirasilva luisfvieirasilva removed their assignment Apr 13, 2023
piotrkira added a commit to piotrkira/libsql-shell-go that referenced this issue Apr 28, 2023
Sqlparser is not maintaned anymore, as it was used just for this simple
thing I've decided to reimplement logic of spliting statements into one
simple function.

Fixes: tursodatabase#50
piotrkira added a commit to piotrkira/libsql-shell-go that referenced this issue Apr 28, 2023
Sqlparser is not maintained anymore, as it was used just for this simple
thing I've decided to re implement logic of spiting statements into one
simple function.

Fixes: tursodatabase#50
piotrkira added a commit to piotrkira/libsql-shell-go that referenced this issue May 12, 2023
Sqlparser is not maintained anymore, as it was used just for this simple
thing I've decided to re implement logic of spiting statements into one
simple function.

Fixes: tursodatabase#50
piotrkira added a commit to piotrkira/libsql-shell-go that referenced this issue May 12, 2023
Sqlparser is not maintained anymore, as it was used just for this simple
thing I've decided to re implement logic of spiting statements into one
simple function.

Related-to: tursodatabase#50
@StefanoSaffran StefanoSaffran removed their assignment May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants