Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails if base is annotated tag #132

Closed
CervEdin opened this issue Nov 15, 2024 · 3 comments
Closed

Fails if base is annotated tag #132

CervEdin opened this issue Nov 15, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@CervEdin
Copy link

running

git absorb --base=annotated-tag --fix

is giving me

Nov 15 17:01:34.073 CRIT absorb failed, err: the requested type does not match the type in the ODB; class=Invalid (3); code=NotFound (-3)
@tummychow
Copy link
Owner

hm... that's unfortunate. probably we have to peel_to_commit instead of find_commit, since the revparse result could be any git object type

@tummychow tummychow added the good first issue Good for newcomers label Nov 15, 2024
@CervEdin
Copy link
Author

Thanks for the quick response!

Guessing you're referring to something related to libgit? Not familiar with that.
Annotated commit are peculiar refs, since they have a hash which is different from the underlying ref which they refer to and I would guess that's the underlying cause for whatever is happening here

In general, I would expect to be able to use any valid refspec as --base.

@tummychow
Copy link
Owner

#135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants