Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -m #129

Open
wcampbell0x2a opened this issue Nov 4, 2024 · 1 comment
Open

Add support for -m #129

wcampbell0x2a opened this issue Nov 4, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@wcampbell0x2a
Copy link

Many times, I will use git-commit --fixup with -m to remember what I am fixing up, and send more context to the reviewer reading the fixup commit.

Any interest in adding a -m, where the commit message is applied to every commit git-absorb adds?

@tummychow
Copy link
Owner

i'm on the fence about this. the functionality seems very niche - people who rebase away the fixups before pushing will never use this. furthermore, the only way this can be supported is to add the same string to every single commit, so you can't exactly put a specific message on each one. what's the practical value of adding the same string to all the fixups?

on the other hand, the implementation would be very small, so i guess i'll accept a pr for this. i will not accept a pr for anything that involves opening an editor to set the message. fixed string specified on the cli only

@tummychow tummychow added the good first issue Good for newcomers label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants