Removed passing default value to geometry context argument in several functions in detray core

Addapted tests and tutorials to this change

Author: Vakho Tsulaia

core/include/detray/navigation/navigator.hpp

@@ -762,7 +762,7 @@ class navigator {
     template <typename track_t>
     DETRAY_HOST_DEVICE inline bool update_kernel(
         const track_t &track, state &navigation, const navigation::config &cfg,
-        const context_type &ctx = {}) const {
+        const context_type &ctx) const {
 
         const auto &det = navigation.detector();
 

core/include/detray/propagator/base_stepper.hpp

@@ -85,7 +85,7 @@ class base_stepper {
         DETRAY_HOST_DEVICE state(
             const bound_track_parameters_type &bound_params,
             const detector_t &det,
-            const typename detector_t::geometry_context &ctx = {})
+            const typename detector_t::geometry_context &ctx)
             : m_bound_params(bound_params) {
 
             // Surface

core/include/detray/propagator/propagator.hpp

@@ -68,7 +68,7 @@ struct propagator {
         /// Construct the propagation state with free parameter
         DETRAY_HOST_DEVICE state(const free_track_parameters_type &free_params,
                                  const detector_type &det,
-                                 const context_type &ctx = {})
+                                 const context_type &ctx)
             : _stepping(free_params), _navigation(det), _context(ctx) {}
 
         /// Construct the propagation state with free parameter
@@ -106,7 +106,7 @@ struct propagator {
         DETRAY_HOST_DEVICE state(const bound_track_parameters_type &param,
                                  const detector_type &det,
                                  const context_type &ctx = {})
-            : _stepping(param, det), _navigation(det), _context(ctx) {}
+            : _stepping(param, det, ctx), _navigation(det), _context(ctx) {}
 
         /// Construct the propagation state with bound parameter
         template <typename field_t>

core/include/detray/propagator/rk_stepper.hpp

@@ -80,7 +80,7 @@ class rk_stepper final
         DETRAY_HOST_DEVICE state(
             const bound_track_parameters_type& bound_params,
             const magnetic_field_t& mag_field, const detector_t& det,
-            const typename detector_t::geometry_context& ctx = {})
+            const typename detector_t::geometry_context& ctx)
             : base_type::state(bound_params, det, ctx),
               m_magnetic_field(mag_field) {}
 

tests/include/detray/test/validation/material_validation_utils.hpp

@@ -262,7 +262,7 @@ inline auto record_material(
         detray::tie(pathlimit_aborter_state, transporter_state, resetter_state,
                     interactor_state, mat_tracer_state);
 
-    typename propagator_t::state propagation{track, det};
+    typename propagator_t::state propagation{track, det, cfg.context};
 
     // Run the propagation
     bool success = prop.propagate(propagation, actor_states);

tests/include/detray/test/validation/navigation_validation_utils.hpp

@@ -38,7 +38,7 @@ struct empty_bfield {};
 template <typename stepper_t, typename detector_t,
           typename bfield_t = empty_bfield>
 inline auto record_propagation(
-    const typename detector_t::geometry_context,
+    const typename detector_t::geometry_context ctx,
     vecmem::memory_resource *host_mr, const detector_t &det,
     const propagation::config &cfg,
     const free_track_parameters<typename detector_t::algebra_type> &track,
@@ -88,10 +88,10 @@ inline auto record_propagation(
     std::unique_ptr<typename propagator_t::state> propagation{nullptr};
     if constexpr (std::is_same_v<bfield_t, empty_bfield>) {
         propagation =
-            std::make_unique<typename propagator_t::state>(track, det);
+            std::make_unique<typename propagator_t::state>(track, det, ctx);
     } else {
         propagation =
-            std::make_unique<typename propagator_t::state>(track, bfield, det);
+            std::make_unique<typename propagator_t::state>(track, bfield, det, ctx);
     }
 
     // Access to navigation information

tests/integration_tests/cpu/propagator/propagator.cpp

@@ -140,7 +140,7 @@ GTEST_TEST(detray_propagator, propagator_line_stepper) {
     propagation::config prop_cfg{};
     propagator_t p{prop_cfg};
 
-    propagator_t::state state(track, d);
+    propagator_t::state state(track, d, prop_cfg.context);
 
     EXPECT_TRUE(p.propagate(state))
         << state._navigation.inspector().to_string() << std::endl;

tests/unit_tests/cpu/propagator/covariance_transport.cpp

@@ -97,7 +97,7 @@ GTEST_TEST(detray_propagator, covariance_transport) {
     propagation::config prop_cfg{};
     prop_cfg.navigation.overstep_tolerance = -100.f * unit<float>::um;
     propagator_t p{prop_cfg};
-    propagator_t::state propagation(bound_param0, det);
+    propagator_t::state propagation(bound_param0, det, prop_cfg.context);
 
     // Run propagator
     p.propagate(propagation, detray::tie(bound_updater, rst));

tutorials/src/cpu/propagation/navigation_inspection.cpp

@@ -91,7 +91,7 @@ int main() {
         // the same volumes and distances along the way
         detray::free_track_parameters<detray::tutorial::algebra_t> track(
             ray.pos(), 0.f, ray.dir(), -1.f);
-        propagator_t::state propagation(track, det);
+        propagator_t::state propagation(track, det, prop_cfg.context);
 
         // Run the actual propagation
         prop.propagate(propagation);