TMP commit

Extra checks and printouts

Author: Vakho Tsulaia

tests/unit_tests/device/cuda/detector_cuda.cpp

@@ -129,19 +129,37 @@ TEST(detector_cuda, detector_alignment) {
     // for populating this vector take all transforms of the detector
     // and shift them by the same translation
     typename detector_host_t::transform_container tf_store_aligned_host;
+    typename decltype(det_host)::transform_container::context_type ctx{};
 
-    point3 shift{.100000f * unit<scalar>::mm, .200000f * unit<scalar>::mm,
-                 .300000f * unit<scalar>::mm};
+    point3 shift{.1f * unit<scalar>::mm, .2f * unit<scalar>::mm,
+                 .3f * unit<scalar>::mm};
 
     tf_store_aligned_host.reserve(
         det_host.transform_store().size(),
-        typename decltype(det_host)::transform_container::context_type{});
+        ctx);
 
     for (const auto& tf : det_host.transform_store()) {
-        point3 shifted = tf.translation() + shift;
+        point3 shifted{tf.translation()[0] + shift[0],
+		       tf.translation()[1] + shift[1],
+		       tf.translation()[2] + shift[2]};
         tf_store_aligned_host.push_back(
             transform_t{shifted, tf.x(), tf.y(), tf.z()});
     }
+/*
+    std::cout << "Comparing translations STEP1" << std::endl;
+    for (unsigned int i = 0u; i < 20; i++) {
+	auto trstatic = det_host.transform_store().at(i,ctx).translation();
+	auto traligned = tf_store_aligned_host.at(i,ctx).translation();
+	auto trdiff = traligned - trstatic;
+	EXPECT_POINT3_NEAR(trdiff, shift, 1e-6);
+    }
+*/
+
+    // Corrected shift
+    auto tr0_static = det_host.transform_store().at(0,ctx).translation();
+    auto tr0_aligned = tf_store_aligned_host.at(0,ctx).translation();
+    auto tr0_diff = tr0_aligned-tr0_static;
+    point3 shift_corrected{tr0_diff[0],tr0_diff[1],tr0_diff[2]};
 
     // copy the vector of aligned transforms to the device
     // again, use synchronous copy and fixed size buffers
@@ -173,10 +191,11 @@ TEST(detector_cuda, detector_alignment) {
                             surfacexf_data_static, surfacexf_data_aligned);
 
     // check that the relevant transforms have been properly shifted
+    // std::cout << "Comparing translations STEP3" << std::endl;
     for (unsigned int i = 0u; i < surfacexf_device_static.size(); i++) {
         auto translation_static = surfacexf_device_static[i].translation();
         auto translation_aligned = surfacexf_device_aligned[i].translation();
         auto translation_diff = translation_aligned - translation_static;
-        EXPECT_POINT3_NEAR(translation_diff, shift, 1e-5);
+        EXPECT_POINT3_NEAR(translation_diff, shift_corrected, 1e-6);
     }
 }

tests/unit_tests/device/cuda/detector_cuda_kernel.cu

@@ -127,7 +127,28 @@ __global__ void detector_alignment_test_kernel(
         surfacexf_data_static);
     vecmem::device_vector<transform_t> surfacexf_device_aligned(
         surfacexf_data_aligned);
+/*
+    printf("Comparing translations STEP2\n");
+    for (unsigned int i = 0u; i < 20; i++) {
+	const auto sf = tracking_surface{det_device_static,
+		                         det_device_static.surfaces()[i]};
+	auto trstat = sf.transform(ctx).translation();
+	const auto af = tracking_surface{det_device_aligned,
+		                         det_device_aligned.surfaces()[i]};
+	auto tralig = af.transform(ctx).translation();
+	if(fabs(tralig[0]-trstat[0]-.1f)>1e-6
+	   || fabs(tralig[1]-trstat[1]-.2f)>1e-6
+	   || fabs(tralig[2]-trstat[2]-.3f)>1e-6) {
+	  printf("[%f,%f,%f] - [%f,%f,%f] = [%f,%f,%f]\n",
+	         tralig[0],tralig[1],tralig[2],
+		 trstat[0],trstat[1],trstat[2],
+		 fabs(tralig[0]-trstat[0]),
+		 fabs(tralig[1]-trstat[1]),
+		 fabs(tralig[2]-trstat[2]));
+	}
 
+    }
+*/
     // copy surface transforms into relevant vectors
     for (unsigned int i = 0u; i < det_device_static.surfaces().size(); i++) {
         const auto sf = tracking_surface{det_device_static,