From c22647ed34312aa9778d98d727057dce6fd26195 Mon Sep 17 00:00:00 2001 From: Timo Reichl Date: Tue, 12 Sep 2023 20:52:19 +0200 Subject: [PATCH 1/4] CI: Update actions/checkout to v4 Signed-off-by: Timo Reichl --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 78df2a9..6705545 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -5,7 +5,7 @@ jobs: build-linux-gcc: runs-on: ubuntu-18.04 steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v4 - name: build run: | $CC nobuild.c -o nobuild @@ -16,7 +16,7 @@ jobs: build-linux-clang: runs-on: ubuntu-18.04 steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v4 - name: build run: | $CC nobuild.c -o nobuild @@ -27,7 +27,7 @@ jobs: build-macos: runs-on: macOS-latest steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v4 - name: build run: | $CC nobuild.c -o nobuild @@ -38,7 +38,7 @@ jobs: build-windows-msvc: runs-on: windows-2019 steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v4 # this runs vcvarsall for us, so we get the MSVC toolchain in PATH. - uses: seanmiddleditch/gha-setup-vsdevenv@master - name: build From e22e3299125076b62a0f6e76984ca99a219aab51 Mon Sep 17 00:00:00 2001 From: Timo Reichl Date: Tue, 12 Sep 2023 20:52:26 +0200 Subject: [PATCH 2/4] CI: Use ubuntu-latest for Linux builds According to https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources, `ubuntu-18.04` is not supported anymore. I would've changed it to `ubuntu-20.04`, but as soon as Canonical releases Ubuntu 24.04, `ubuntu-20.04` will get deprecated again (I guess). So I think `ubuntu-latest` is fine. Signed-off-by: Timo Reichl --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6705545..aca2887 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,7 +3,7 @@ on: [push, pull_request] jobs: build-linux-gcc: - runs-on: ubuntu-18.04 + runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - name: build @@ -14,7 +14,7 @@ jobs: CC: gcc CXX: g++ build-linux-clang: - runs-on: ubuntu-18.04 + runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - name: build From 65d32fb52e0a94ebe9efd5a9e95510c88e0df1c0 Mon Sep 17 00:00:00 2001 From: Timo Reichl Date: Tue, 12 Sep 2023 20:54:02 +0200 Subject: [PATCH 3/4] CI: Use windows-latest for Windows builds Same reasoning as for `ubuntu-latest`. Signed-off-by: Timo Reichl --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index aca2887..d85bdf5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -36,7 +36,7 @@ jobs: CC: clang CXX: clang++ build-windows-msvc: - runs-on: windows-2019 + runs-on: windows-latest steps: - uses: actions/checkout@v4 # this runs vcvarsall for us, so we get the MSVC toolchain in PATH. From cc7326749a490d2013228631119b694e18431985 Mon Sep 17 00:00:00 2001 From: Timo Reichl Date: Tue, 12 Sep 2023 20:56:11 +0200 Subject: [PATCH 4/4] CI: Replace seanmiddleditch/gha-setup-vsdevenv@master with TheMrMilchmann/setup-msvc-dev@v2.0.1 for Windows builds This fixes a lot of issues which point to outdated node12 and outdated/deprecated syntax for build outputs being used. Signed-off-by: Timo Reichl --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d85bdf5..4125a7b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,11 +39,11 @@ jobs: runs-on: windows-latest steps: - uses: actions/checkout@v4 - # this runs vcvarsall for us, so we get the MSVC toolchain in PATH. - - uses: seanmiddleditch/gha-setup-vsdevenv@master + - uses: TheMrMilchmann/setup-msvc-dev@v2 # prepare Visual Studio C++ toolchain + with: + arch: x64 - name: build - shell: cmd - # this replaces default PowerShell, which can't fail the build + shell: cmd # this replaces default PowerShell, which can't fail the build run: | cl.exe nobuild.c .\nobuild.exe test