Skip to content

String.prototype.replace does not work with replacement patterns #938

Open
#991
Open
String.prototype.replace does not work with replacement patterns#938
#991
Labels
enhancementNew feature or requestgood first issueGood for newcomers

Description

@ChALkeR
ChALkeR
opened on Feb 8, 2026
> 'abc'.replaceAll(/(b)/g,'[$1]')
SmallString("a[$1]c")
> 'abc'.replaceAll(/(b)/g,'[$$]')
SmallString("a[$$]c")

Should be:

> 'abc'.replaceAll(/(b)/g,'[$1]')
'a[b]c'
> 'abc'.replaceAll(/(b)/g,'[$$]')
'a[$]c'

Activity

  1. ChALkeR
    added a commit that references this issue on Feb 9, 2026

    chore: prefer function replacers

    696012d
  2. aapoalas
    added
    bugSomething isn't working
    good first issueGood for newcomers
    on Feb 9, 2026

  3. aapoalas commented on Feb 9, 2026

    @aapoalas
    aapoalas
    on Feb 9, 2026
    Member

    Whoops right, we've completely forgot to consider replacement patterns.

  4. aapoalas
    added
    enhancementNew feature or request
    and removed
    bugSomething isn't working
    on Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestgood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions