Skip to content

Conversation

@brandonlenz
Copy link
Contributor

Summary

There was some off wrapping behavior on this story that I noticed while testing #3266. The USWDS example was working fine. Turns out one of our classes in the story was simply (likely) copy pasted incorrectly at some point.

How To Test

yarn storybook

Then fiddle with screen width

Screenshots (optional)

Before:
image

After:
image

image

Author & Maintainer checklist

  • Is this is a breaking change?
    • Yes, and I accounted for the breaking changes according to the linked documentation
    • No
  • Once merged, add the PR and Issue author(s) as a contributor(s) via the all-contributors bot

@brandonlenz brandonlenz requested a review from a team as a code owner November 17, 2025 12:47
@brandonlenz brandonlenz changed the title Fix: Apply consistent USWDS class in slim Footer storybook example fix: Apply consistent USWDS class in slim Footer storybook example Nov 17, 2025
/>
</div>
<div className="tablet:grid-col-4">
<div className="mobile-lg:grid-col-4">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The context of why this change needed to be made is more visible expanding the section above to see the other grid col class:

Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When grid col's don't match, things get weird 😆

Copy link
Contributor

@rswerve rswerve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@brandonlenz brandonlenz enabled auto-merge (squash) November 17, 2025 13:20
@brandonlenz brandonlenz merged commit f3d48aa into main Nov 17, 2025
9 checks passed
@brandonlenz brandonlenz deleted the bl-fix-footer-story-class branch November 17, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants