fix: validate DatePicker on blur #3189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-wright
changed the title
Contributor
|
@elijah-wright hello! i noticed this is marked Draft. is this PR still being worked on? |
Author
|
yea, I just wanted more feedback first, esp because I also added sending validation to the user |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this PR fixes the skipped tests in
DatePicker.test.tsxby adjustingDatePickerto validate on blur rather than with auseEffecthook, which matches with USWDS. it also sets thearia-invalidattribute and usesreportValidityto sendVALIDATION_MESSAGEto the user. this PR also changes some of the tests that were dependent on theuseEffectbehaviorRelated Issues or PRs
none
How To Test
yarn test