Skip to content

Commit 90e8c69

Browse files
authored
client: set no default client timeout for a2a-go (#80)
* client: set no default client timeout for a2a-go * fix test
1 parent a36121b commit 90e8c69

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

client/client.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import (
1818
"net/http"
1919
"net/url"
2020
"strings"
21-
"time"
2221

2322
"trpc.group/trpc-go/trpc-a2a-go/auth"
2423
"trpc.group/trpc-go/trpc-a2a-go/internal/jsonrpc"
@@ -28,7 +27,7 @@ import (
2827
)
2928

3029
const (
31-
defaultTimeout = 60 * time.Second
30+
defaultTimeout = 0 // Default to no timeout for client, let user decide the timeout.
3231
defaultUserAgent = "trpc-a2a-go-client/0.1"
3332
)
3433

client/options_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func TestWithHTTPClient(t *testing.T) {
3535
defaultClient, err := NewA2AClient("http://localhost:8080", WithHTTPClient(nil))
3636
require.NoError(t, err)
3737
assert.NotNil(t, defaultClient.httpClient)
38-
assert.Equal(t, defaultTimeout, defaultClient.httpClient.Timeout)
38+
assert.EqualValues(t, defaultTimeout, defaultClient.httpClient.Timeout)
3939
}
4040

4141
func TestWithTimeout(t *testing.T) {
@@ -49,7 +49,7 @@ func TestWithTimeout(t *testing.T) {
4949
// Test with zero timeout (should use default)
5050
defaultClient, err := NewA2AClient("http://localhost:8080", WithTimeout(0))
5151
require.NoError(t, err)
52-
assert.Equal(t, defaultTimeout, defaultClient.httpClient.Timeout)
52+
assert.EqualValues(t, defaultTimeout, defaultClient.httpClient.Timeout)
5353
}
5454

5555
func TestWithUserAgent(t *testing.T) {

0 commit comments

Comments
 (0)