[FEATURE] Only inject content_scripts on specifically supported sites

[0xdevalias]

Is your feature request related to a problem? Please describe.

When browsing random sites, I sometimes notice errors/warnings from this extension in the DevTools console. I wouldn't have expected it to try and run on all sites.

Looking at the manifest, it appears as though it injects its content scripts into all sites:

sonarr-radarr-lidarr-autosearch-browser-extension/src/manifest-chromium/manifest.json

Lines 34 to 48 in 8c86c67

	"content_scripts": [
	{
	"matches": [
	"*://*/*",
	"file://*/*"
	],
	"js": [
	"content/js/jquery.min.js",
	"content/js/browser-polyfill.min.js",
	"content/js/core.js",
	"content/js/sonarr_radarr_lidarr_autosearch.js"
	],
	"run_at": "document_end"
	}
	],

Describe the solution you'd like

Ideally it would only inject into the specific sites that it supports monitoring, which I assume are these:

sonarr-radarr-lidarr-autosearch-browser-extension/src/manifest-chromium/manifest.json

Lines 55 to 74 in 8c86c67

	"host_permissions": [
	"*://*.imdb.com/*",
	"*://*.themoviedb.org/*",
	"*://*.thetvdb.com/*",
	"*://*.trakt.tv/*",
	"*://*.tvmaze.com/*",
	"*://*.musicbrainz.org/*",
	"*://*.letterboxd.com/*",
	"*://*.pogdesign.co.uk/*",
	"*://*.rottentomatoes.com/*",
	"*://*.metacritic.com/*",
	"*://*.simkl.com/*",
	"*://*.iptorrents*",
	"*://*.last.fm/*",
	"*://*.allocine.fr/*",
	"*://*.myanimelist.net/*",
	"*://*.betaseries.com/*",
	"*://*.primevideo.com/*",
	"<all_urls>"
	]

And then ideally would also take into account which are enabled (or not) on this settings page:

[trossr32]

This was already raised in #145 and isn't possible; see: #145 (comment)

[0xdevalias]

This was already raised in #145 and isn't possible; see: #145 (comment)

FYI This change is being reverted in v2.8.1. All URLs permission is required because the extension performs the automated search on servarr instances, and this has broken since the release of v2.8.0.

There's no way to know what the URL of anyone's servarr instance would be, so URL limiting is just not possible.

Originally posted by @trossr32 in #145

@trossr32 I'm not sure about in Firefox/etc, but within Chrome, would the chrome.permissions API allow for this?

• https://developer.chrome.com/docs/extensions/reference/api/permissions

  • Use the chrome.permissions API to request declared optional permissions at run time rather than install time, so users understand why the permissions are needed and grant only those that are necessary.

This part specifically looks relevant, and makes me think it should be possible:

If you want to request hosts that you only discover at runtime, include "https://*/*" in your extension's optional_host_permissions field. This lets you specify any origin in "Permissions.origins" as long as it has a matching scheme.

[0xdevalias]

@trossr32 Any chance of re-opening this issue based on the above? Since it sounds like it is possible to support now.