You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/** * Return the names of configuration properties for this Plugin which may contain sensitive values. * This will be used by the engine to mask the values for those properties to avoid leaking the values. */defaultSet<String> getSensitiveConfigurationNames()
{
returnemptySet();
}
It's the responsibility of the Plugin authors to ensure the implementation of this is kept up to date. For plugins that ship with Trino we can write a test which verifies all configs annotated with @ConfigSecuritySensitive are members of the set returned by getSensitiveConfigurationNames to help ensure the implementation is up to date.
Masking
The goal is to allow the engine to use this list to mask values for these properties from the:
server log
explain output
event listener events
error messages
The naive implementation we can start with would simply identify all occurrences of the property names and mask their values. This will include false positives too in the cases where the property names are very general (e.g password).
For EventListener we propose to change the QueryMetadata#getQuery to return masked query text and introduce a new QueryMetadata#getRawQuery to return unmasked values.
The text was updated successfully, but these errors were encountered:
Proposal
Connector
@ConfigSecuritySensitive
are members of the set returned bygetSensitiveConfigurationNames
to help ensure the implementation is up to date.Masking
The goal is to allow the engine to use this list to mask values for these properties from the:
The naive implementation we can start with would simply identify all occurrences of the property names and mask their values. This will include false positives too in the cases where the property names are very general (e.g
password
).For
EventListener
we propose to change theQueryMetadata#getQuery
to return masked query text and introduce a newQueryMetadata#getRawQuery
to return unmasked values.The text was updated successfully, but these errors were encountered: