fixup! Have build-success as the last job in the workflow

Author: findepi

testing/trino-tests/src/test/java/io/trino/tests/ci/TestCiWorkflow.java

@@ -103,24 +103,22 @@ public void testUploadTestResultsCondition()
     public void testBuildSuccessDependencies()
             throws Exception
     {
-        String buildSuccessJobName = BUILD_SUCCESS;
-
         Yaml yaml = new Yaml();
         Map<?, ?> workflow = yaml.load(new StringReader(Files.readString(findRepositoryRoot().resolve(CI_YML_REPO_PATH))));
         Map<String, ?> jobs = getMap(workflow, "jobs");
 
         Set<String> allJobNames = jobs.keySet();
-        assertThat(allJobNames).as("allJobNames").contains(buildSuccessJobName);
+        assertThat(allJobNames).as("allJobNames").contains(BUILD_SUCCESS);
         List<String> testJobNames = allJobNames.stream()
-                .filter(not(buildSuccessJobName::equals))
+                .filter(not(BUILD_SUCCESS::equals))
                 .sorted()
                 .toList();
-        Map<?, ?> buildSuccessJob = getMap(jobs, buildSuccessJobName);
+        Map<?, ?> buildSuccessJob = getMap(jobs, BUILD_SUCCESS);
 
         List<String> buildSuccessDependencies = getList(buildSuccessJob, "needs").stream()
                 .map(String.class::cast)
                 .toList();
-        assertThat(buildSuccessDependencies).as("dependencies for %s", buildSuccessJobName)
+        assertThat(buildSuccessDependencies).as("dependencies for %s", BUILD_SUCCESS)
                 .isSorted()
                 .doesNotHaveDuplicates()
                 .containsExactlyElementsOf(testJobNames);
@@ -143,14 +141,13 @@ public void testBuildSuccessDependencies()
     public void testBuildSuccessIsLast()
             throws Exception
     {
-        String buildSuccessJobName = BUILD_SUCCESS;
         Yaml yaml = new Yaml();
         Map<?, ?> workflow = yaml.load(new StringReader(Files.readString(findRepositoryRoot().resolve(CI_YML_REPO_PATH))));
         Map<String, ?> jobs = getMap(workflow, "jobs");
         // This assumes the `jobs` map preserves source order
         assertThat(getLast(jobs.keySet()))
-                .describedAs("The %s job is logically last and depends on all others, we want it to be last in the source file".formatted(buildSuccessJobName))
-                .isEqualTo(buildSuccessJobName);
+                .describedAs("The %s job is logically last and depends on all others, we want it to be last in the source file", BUILD_SUCCESS)
+                .isEqualTo(BUILD_SUCCESS);
     }
 
     private static Path findRepositoryRoot()