Remove deprecated gcs.use-access-token from gcs filesystem

Author: chenjian2664

docs/src/main/sphinx/object-storage/file-system-gcs.md

@@ -68,9 +68,6 @@ Cloud Storage:
 
 * - Property
   - Description
-* - `gcs.use-access-token`
-  - Flag to set usage of a client-provided OAuth 2.0 token to access Google
-    Cloud Storage. Defaults to `false`, deprecated to use `gcs.auth-type` instead.
 * - `gcs.auth-type`
   - Authentication type to use for Google Cloud Storage access. Default to `SERVICE_ACCOUNT`.
   Supported values are:

lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsFileSystemConfig.java

@@ -16,12 +16,12 @@
 import io.airlift.configuration.Config;
 import io.airlift.configuration.ConfigDescription;
 import io.airlift.configuration.ConfigSecuritySensitive;
+import io.airlift.configuration.DefunctConfig;
 import io.airlift.configuration.validation.FileExists;
 import io.airlift.units.DataSize;
 import io.airlift.units.Duration;
 import io.airlift.units.MinDuration;
 import jakarta.annotation.Nullable;
-import jakarta.validation.constraints.AssertFalse;
 import jakarta.validation.constraints.AssertTrue;
 import jakarta.validation.constraints.Min;
 import jakarta.validation.constraints.NotNull;
@@ -32,6 +32,7 @@
 
 import static io.airlift.units.DataSize.Unit.MEGABYTE;
 
+@DefunctConfig({"gcs.use-access-token"})
 public class GcsFileSystemConfig
 {
     public enum AuthType
@@ -158,20 +159,6 @@ public GcsFileSystemConfig setAuthType(AuthType authType)
         return this;
     }
 
-    @Deprecated
-    public boolean isUseGcsAccessToken()
-    {
-        return useGcsAccessToken.orElse(false);
-    }
-
-    @Deprecated
-    @Config("gcs.use-access-token")
-    public GcsFileSystemConfig setUseGcsAccessToken(boolean useGcsAccessToken)
-    {
-        this.useGcsAccessToken = Optional.of(useGcsAccessToken);
-        return this;
-    }
-
     @Nullable
     public String getJsonKey()
     {
@@ -303,10 +290,4 @@ public boolean isAuthMethodValid()
 
         return (jsonKey == null) ^ (jsonKeyFilePath == null);
     }
-
-    @AssertFalse(message = "Cannot set both gcs.use-access-token and gcs.auth-type")
-    public boolean isAuthTypeAndGcsAccessTokenConfigured()
-    {
-        return authType.isPresent() && useGcsAccessToken.isPresent();
-    }
 }

lib/trino-filesystem-gcs/src/test/java/io/trino/filesystem/gcs/TestGcsFileSystemConfig.java

@@ -17,7 +17,6 @@
 import io.airlift.units.DataSize;
 import io.airlift.units.Duration;
 import io.trino.filesystem.gcs.GcsFileSystemConfig.AuthType;
-import jakarta.validation.constraints.AssertFalse;
 import jakarta.validation.constraints.AssertTrue;
 import org.junit.jupiter.api.Test;
 
@@ -43,7 +42,6 @@ void testDefaults()
                 .setWriteBlockSize(DataSize.of(16, MEGABYTE))
                 .setPageSize(100)
                 .setBatchSize(100)
-                .setUseGcsAccessToken(false)
                 .setProjectId(null)
                 .setEndpoint(Optional.empty())
                 .setAuthType(AuthType.SERVICE_ACCOUNT)
@@ -90,44 +88,7 @@ void testExplicitPropertyMappings()
                 .setMinBackoffDelay(new Duration(20, MILLISECONDS))
                 .setMaxBackoffDelay(new Duration(20, MILLISECONDS))
                 .setApplicationId("application id");
-        assertFullMapping(properties, expected, Set.of("gcs.json-key", "gcs.json-key-file-path", "gcs.use-access-token"));
-    }
-
-    // backwards compatibility test, remove if use-access-token is removed
-    @Test
-    void testExplicitPropertyMappingsWithDeprecatedUseAccessToken()
-    {
-        Map<String, String> properties = ImmutableMap.<String, String>builder()
-                .put("gcs.read-block-size", "51MB")
-                .put("gcs.write-block-size", "52MB")
-                .put("gcs.page-size", "10")
-                .put("gcs.batch-size", "11")
-                .put("gcs.project-id", "project")
-                .put("gcs.endpoint", "http://custom.dns.org:8000")
-                .put("gcs.use-access-token", "true")
-                .put("gcs.client.max-retries", "10")
-                .put("gcs.client.backoff-scale-factor", "4.0")
-                .put("gcs.client.max-retry-time", "10s")
-                .put("gcs.client.min-backoff-delay", "20ms")
-                .put("gcs.client.max-backoff-delay", "20ms")
-                .put("gcs.application-id", "application id")
-                .buildOrThrow();
-
-        GcsFileSystemConfig expected = new GcsFileSystemConfig()
-                .setReadBlockSize(DataSize.of(51, MEGABYTE))
-                .setWriteBlockSize(DataSize.of(52, MEGABYTE))
-                .setPageSize(10)
-                .setBatchSize(11)
-                .setProjectId("project")
-                .setEndpoint(Optional.of("http://custom.dns.org:8000"))
-                .setUseGcsAccessToken(true)
-                .setMaxRetries(10)
-                .setBackoffScaleFactor(4.0)
-                .setMaxRetryTime(new Duration(10, SECONDS))
-                .setMinBackoffDelay(new Duration(20, MILLISECONDS))
-                .setMaxBackoffDelay(new Duration(20, MILLISECONDS))
-                .setApplicationId("application id");
-        assertFullMapping(properties, expected, Set.of("gcs.json-key", "gcs.json-key-file-path", "gcs.auth-type"));
+        assertFullMapping(properties, expected, Set.of("gcs.json-key", "gcs.json-key-file-path"));
     }
 
     @Test
@@ -165,37 +126,5 @@ public void testValidation()
                 "retryDelayValid",
                 "gcs.client.min-backoff-delay must be less than or equal to gcs.client.max-backoff-delay",
                 AssertTrue.class);
-
-        assertFailsValidation(
-                new GcsFileSystemConfig()
-                        .setAuthType(AuthType.ACCESS_TOKEN)
-                        .setUseGcsAccessToken(true),
-                "authTypeAndGcsAccessTokenConfigured",
-                "Cannot set both gcs.use-access-token and gcs.auth-type",
-                AssertFalse.class);
-
-        assertFailsValidation(
-                new GcsFileSystemConfig()
-                        .setAuthType(AuthType.ACCESS_TOKEN)
-                        .setUseGcsAccessToken(false),
-                "authTypeAndGcsAccessTokenConfigured",
-                "Cannot set both gcs.use-access-token and gcs.auth-type",
-                AssertFalse.class);
-
-        assertFailsValidation(
-                new GcsFileSystemConfig()
-                        .setUseGcsAccessToken(true)
-                        .setAuthType(AuthType.SERVICE_ACCOUNT),
-                "authTypeAndGcsAccessTokenConfigured",
-                "Cannot set both gcs.use-access-token and gcs.auth-type",
-                AssertFalse.class);
-
-        assertFailsValidation(
-                new GcsFileSystemConfig()
-                        .setUseGcsAccessToken(false)
-                        .setAuthType(AuthType.SERVICE_ACCOUNT),
-                "authTypeAndGcsAccessTokenConfigured",
-                "Cannot set both gcs.use-access-token and gcs.auth-type",
-                AssertFalse.class);
     }
 }